Skip to content

fix: "Reply in direct message" action not visible for users with create DM permission #40078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dionisio-bot merged 5 commits into from
Apr 13, 2026
Merged

fix: "Reply in direct message" action not visible for users with create DM permission #40078

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69e575d
fix: Reply in DM action visibility check
ricardogarim Apr 7, 2026
bea8082
test: add e2e tests for Reply in DM permission visibility
ricardogarim Apr 8, 2026
daef4a1
refactor: use page object for Reply in DM menu item locator in e2e tests
ricardogarim Apr 8, 2026
c144392
refactor: avoid hardcoded roles in Reply in DM e2e tests
ricardogarim Apr 13, 2026
704f48b
fix: change test position and reduce unnecessary permission api call
dougfabris Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: use page object for Reply in DM menu item locator in e2e tests
  • Loading branch information
@ricardogarim
ricardogarim committed Apr 8, 2026
commit daef4a13c877e92aa76908c76743913453b90fea
8 changes: 4 additions & 4 deletions apps/meteor/tests/e2e/message-actions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,11 @@ test.describe.serial('message-actions', () => {
await sendTargetChannelMessage(api, targetChannel, { msg: 'message from admin for reply in DM' });
});

test('expect option not be visible without create-d permission and no existing DM', async ({ page, api }) => {
test('expect option not be visible without create-d permission and no existing DM', async ({ api }) => {
expect((await api.post('/permissions.update', { permissions: [{ _id: 'create-d', roles: ['admin'] }] })).status()).toBe(200);

await poHomeChannel.content.openLastMessageMenu();
await expect(page.locator('role=menuitem[name="Reply in direct message"]')).toBeHidden();
await expect(poHomeChannel.content.btnOptionReplyInDm).toBeHidden();
});

test('expect option be visible and redirect to DM', async ({ page, api }) => {
Expand All @@ -182,7 +182,7 @@ test.describe.serial('message-actions', () => {
).toBe(200);

await poHomeChannel.content.openLastMessageMenu();
await page.locator('role=menuitem[name="Reply in direct message"]').click();
await poHomeChannel.content.btnOptionReplyInDm.click();

await expect(page).toHaveURL(/.*reply/);
});
Expand All @@ -209,7 +209,7 @@ test.describe.serial('message-actions', () => {
test('expect reply the message in direct', async ({ page }) => {
await poHomeChannel.content.sendMessage('this is a message for reply in direct');
await poHomeChannel.content.openLastMessageMenu();
await page.locator('role=menuitem[name="Reply in direct message"]').click();
await poHomeChannel.content.btnOptionReplyInDm.click();

await expect(page).toHaveURL(/.*reply/);
});
Expand Down
4 changes: 4 additions & 0 deletions apps/meteor/tests/e2e/page-objects/fragments/home-content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,10 @@ export class HomeContent {
return this.menuMore.getByRole('menuitem', { name: 'Star', exact: true });
}

get btnOptionReplyInDm(): Locator {
return this.menuMore.getByRole('menuitem', { name: 'Reply in direct message', exact: true });
}

get btnVoiceCall(): Locator {
return this.primaryRoomActionsToolbar.getByRole('button', { name: 'Voice call' });
}
Expand Down
Loading