Skip to content

Conversation

@ChristophWurst
Copy link
Contributor

As seen in #261 CI fails for PRs against 0.0 due to the composer plugin not being allowed.

Signed-off-by: Christoph Wurst <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ChristophWurst
Copy link
Contributor Author

PHPStan doesn't like this branch it seems.

Before I end up like this, let me know if you accept the patch #260 and if green CI is a hard requirement.

@andrewdalpino
Copy link
Member

Nah, we don't need to be green. This is an older branch and PHPStan has a way of creeping up on you if it hasn't been updated in a while.

@andrewdalpino andrewdalpino merged commit c67f999 into RubixML:0.0 Oct 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2022
@ChristophWurst ChristophWurst deleted the chore/allow-phpstan-plugin-0.0 branch October 14, 2022 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants