Skip to content

Conversation

@tarcieri
Copy link
Member

@tarcieri tarcieri commented Jul 11, 2020

Conditionally implements public key recovery for recoverable::Signature when the arithmetic and sha256 Cargo features are enabled.

Recovery is only implemented for "recovery IDs" 0 and 1, as these are the only ones that occur in practice.

@cargo-dep-bot
Copy link

cargo-dep-bot bot commented Jul 11, 2020

This PR made the following dependency changes:

Added Packages (Duplicate versions in '()'):
	num-bigint 0.3.0
	num-integer 0.1.43

Removed Packages (Remaining versions in '()'):
	fiat-crypto 0.1.5

@tarcieri tarcieri mentioned this pull request Jul 11, 2020
@tarcieri tarcieri force-pushed the k256/ecdsa-recovery branch from 92c0faa to ba32226 Compare July 14, 2020 16:59
@tarcieri tarcieri changed the title [WIP/not for merge] ECDSA public key recovery [WIP] ECDSA public key recovery Jul 14, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 54.87%. Comparing base (6b6758a) to head (b82a98c).
Report is 988 commits behind head on master.

Files with missing lines Patch % Lines
k256/src/ecdsa/recoverable.rs 0.00% 41 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   55.51%   54.87%   -0.64%     
==========================================
  Files          15       15              
  Lines        2918     2952      +34     
==========================================
  Hits         1620     1620              
- Misses       1298     1332      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Conditionally implements public key recovery for
`recoverable::Signature` when the `arithmetic` and `sha256`
Cargo features are enabled.

Recovery is only implemented for "recovery IDs" 0 and 1, as these are
the only ones that occur in practice.
@tarcieri tarcieri force-pushed the k256/ecdsa-recovery branch from 6432ba6 to b82a98c Compare July 16, 2020 19:20
@tarcieri tarcieri changed the title [WIP] ECDSA public key recovery k256: Add recoverable::Signature::recovery_pubkey Jul 16, 2020
@tarcieri tarcieri marked this pull request as ready for review July 16, 2020 19:24
@tarcieri tarcieri changed the title k256: Add recoverable::Signature::recovery_pubkey k256: Add recoverable::Signature::recover_pubkey Jul 16, 2020
@tarcieri tarcieri merged commit c103631 into master Jul 16, 2020
@tarcieri tarcieri deleted the k256/ecdsa-recovery branch July 16, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants