argon2: refactor Params handling
#213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
argon2/refactor-params-handling
branch
from
1dd30c2 to
aaeae85
Compare
Uses `Params` internally within the `Argon2` context, refactoring all of the logic related to parameter handling into that type/module: - Changes `Argon2::new` to accept explicit `version` and `params` - Factors apart `Argon2::new` and `Argon2::new_with_secret`, making the former infallible. - Makes the `Params` struct opaque with field accessors, and ensures it always represents a valid set of parameters. - Removes `version` parameter from `hash_password_into`, using the one supplied to `Argon2::new`.
tarcieri
force-pushed
the
argon2/refactor-params-handling
branch
from
aaeae85 to
4ea898d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
Paramsinternally within theArgon2context, refactoring all of the logic related to parameter handling into that type/module:Argon2::newto accept explicitversionandparamsArgon2::newandArgon2::new_with_secret, making the former infallible.Paramsstruct opaque with field accessors, and ensures it always represents a valid set of parameters.versionparameter fromhash_password_into, using the one supplied toArgon2::new.