ecdsa: rename asn1::Signature; impl signature trait
#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames `asn1::Document` to `asn1::Signature`. This means we now have the following types: - `ecdsa::Signature`: fixed-sized encoding - `ecdsa::asn1::Signature`: ASN.1 DER encoding Additionally this commit adds an impl of the `signature::Signature` trait for `asn1::Signature`, promoting it back to a first-class signature type. This allows ECDSA `signature::Signer` impls to directly produce ASN.1 encoded signatures again without transcoding, if they so desire.
tarcieri
force-pushed
the
asn1/signature-refactor
branch
from
7db1725 to
053981c
Compare
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 54.44% 53.59% -0.86%
==========================================
Files 3 3
Lines 180 181 +1
==========================================
- Hits 98 97 -1
- Misses 82 84 +2
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames
asn1::Documenttoasn1::Signature.This means we now have the following types:
ecdsa::Signature: fixed-sized encodingecdsa::asn1::Signature: ASN.1 DER encodingAdditionally this commit adds an impl of the
signature::Signaturetrait forasn1::Signature, promoting it back to a first-class signature type. This allows ECDSAsignature::Signerimpls to directly produce ASN.1 encoded signatures again without transcoding, if they so desire.