ecdsa: add DigestPrimitive #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DigestPrimitive` trait, intended to be implemented within a crate which impls `elliptic_curve::weierstrass::Curve`, provides a blanket impl of `PrehashSignature` for `ecdsa::Signature<C: Curve>`. This is a small hack needed to work around the fact that the ECDSA signature trait now lies in an external crate, so crates which implement a specific curve can no longer impl traits on `ecdsa::Signature`.
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 54.44% 54.44%
=======================================
Files 3 3
Lines 180 180
=======================================
Hits 98 98
Misses 82 82
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DigestPrimitivetrait, intended to be implemented within a crate which implselliptic_curve::weierstrass::Curve, provides a blanket impl ofPrehashSignatureforecdsa::Signature<C: Curve>.This is a small hack needed to work around the fact that the ECDSA signature trait now lies in an external crate, so crates which implement a specific curve can no longer impl traits on
ecdsa::Signature.