elliptic-curve: replace FixedBaseScalarMul with ops::MulBase #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FixedBaseScalarMul` was a hack around the lack of an associated `Scalar` type on a curve and generic way of converting a `SecretKey` to a `Scalar`. We have both of those things, so this commit replaces it with an `ops::MulBase` trait intended to be impl'd on `Scalar` types. Further, it bounds the `Arithmetic::Scalar` associated type on this, which allows it to be used for generic `SecretKey` -> `PublicKey` conversions. It also means the `Arithmetic` trait now has a(n implicit) way of representing the generator point, making it genuinely useful for generic arithmetic operations. This would also be useful for e.g. a generic implementation of Diffie-Hellman.
tarcieri
force-pushed
the
elliptic-curve/mul-base-op
branch
from
9806c1b to
96b8e44
Compare
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jul 29, 2020
...and remove the now legacy `FixedBaseScalarMul` trait. This commit impls the changes from RustCrypto/traits#229 and RustCrypto/traits#230: - Adds a `FromSecretKey` impl on `Scalar` - Adds a `FromPublicKey` impl on `AffinePoint` - Adds `MulBase` impl on `Scalar`
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jul 29, 2020
...and remove the now legacy `FixedBaseScalarMul` trait. This commit impls the changes from RustCrypto/traits#229 and RustCrypto/traits#230: - Adds a `FromSecretKey` impl on `Scalar` - Adds a `FromPublicKey` impl on `AffinePoint` - Adds `MulBase` impl on `Scalar`
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jul 29, 2020
...and remove the now legacy `FixedBaseScalarMul` trait. This commit impls the changes from RustCrypto/traits#229 and RustCrypto/traits#230: - Adds a `FromSecretKey` impl on `Scalar` - Adds a `FromPublicKey` impl on `AffinePoint` - Adds `MulBase` impl on `Scalar`
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixedBaseScalarMulwas a hack around the lack of an associatedScalartype on a curve and generic way of converting aSecretKeyto aScalar.We have both of those things, so this commit replaces it with an
ops::MulBasetrait intended to be impl'd onScalartypes.Further, it bounds the
Arithmetic::Scalarassociated type on this, which allows it to be used for genericSecretKey->PublicKeyconversions.It also means the
Arithmetictrait now has a(n implicit) way of representing the generator point, making it genuinely useful for generic arithmetic operations. This would also be useful for e.g. a generic implementation of Diffie-Hellman.