-
Notifications
You must be signed in to change notification settings - Fork 228
elliptic-curve: add encoding module
#247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the previous `FromPublicKey` and `FromSecretKey` traits with a more general `FromBytes` and `ToBytes` traits. These match the function signatures presently used in the existing crates, and are useful in cases where e.g. a scalar doesn't necessarily represent a secret (such as in ECDSA).
tarcieri
added a commit
that referenced
this pull request
Aug 4, 2020
It seems this was a bit too hastily removed in #247. It's worth keeping around for now as it handles the variable sizes of SEC-1 keys.
tarcieri
added a commit
that referenced
this pull request
Aug 4, 2020
It seems this was a bit too hastily removed in #247. It's worth keeping around for now as it handles the variable sizes of SEC-1 keys.
tarcieri
added a commit
that referenced
this pull request
Aug 4, 2020
It seems this was a bit too hastily removed in #247. It's worth keeping around for now as it handles the variable sizes of SEC-1 keys.
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Aug 4, 2020
Uses the new `FromBytes` trait introduced in RustCrypto/traits#247
tarcieri
added a commit
to RustCrypto/signatures
that referenced
this pull request
Aug 4, 2020
Uses the new `FromBytes` trait introduced in RustCrypto/traits#247
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 4, 2020
Impls the new `FromBytes`/`ToBytes` traits introduced in RustCrypto/traits#247
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 4, 2020
Impls the new `FromBytes`/`ToBytes` traits introduced in RustCrypto/traits#247
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 5, 2020
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247, and changes `to_bytes()` to return `ElementBytes`.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 5, 2020
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247, and changes `to_bytes()` to return `ElementBytes`.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 5, 2020
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247, and changes `to_bytes()` to return `ElementBytes`.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 5, 2020
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247, and changes `to_bytes()` to return `ElementBytes`.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Aug 5, 2020
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247, and changes `to_bytes()` to return `ElementBytes`.
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
- Change ParamsBuilder to make it more ergonomic - Remove unnecessary suppressions of dead code warnings - Fix wrong docs for m_cost - Fix wrong doc for Block - Merge `Argon2` and `Instance` structs, remove Memory - Remove parallel feature (to be re-added)
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
- Bump version to `0.5.0-pre` (RustCrypto#247 contained breaking changes) - Use pointer casts to convert `Block` integer array to byte array - Rename `permutate!` to `permute!` (former isn't in OED, latter is)
scv35
added a commit
to scv35/Signature-algorithms
that referenced
this pull request
Jul 4, 2025
Uses the new `FromBytes` trait introduced in RustCrypto/traits#247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the previous
FromPublicKeyandFromSecretKeytraits with a more generalFromBytesandToBytestraits.These match the function signatures presently used in the existing crates, and are useful in cases where e.g. a scalar doesn't necessarily represent a secret (such as in ECDSA).