Skip to content

Conversation

@tarcieri
Copy link
Member

@tarcieri tarcieri commented Aug 4, 2020

Replaces the previous FromPublicKey and FromSecretKey traits with a more general FromBytes and ToBytes traits.

These match the function signatures presently used in the existing crates, and are useful in cases where e.g. a scalar doesn't necessarily represent a secret (such as in ECDSA).

Replaces the previous `FromPublicKey` and `FromSecretKey` traits with a
more general `FromBytes` and `ToBytes` traits.

These match the function signatures presently used in the existing
crates, and are useful in cases where e.g. a scalar doesn't necessarily
represent a secret (such as in ECDSA).
@tarcieri tarcieri merged commit 4554cdc into master Aug 4, 2020
@tarcieri tarcieri deleted the elliptic-curve/encoding branch August 4, 2020 20:55
tarcieri added a commit that referenced this pull request Aug 4, 2020
It seems this was a bit too hastily removed in #247. It's worth keeping
around for now as it handles the variable sizes of SEC-1 keys.
tarcieri added a commit that referenced this pull request Aug 4, 2020
It seems this was a bit too hastily removed in #247. It's worth keeping
around for now as it handles the variable sizes of SEC-1 keys.
tarcieri added a commit that referenced this pull request Aug 4, 2020
It seems this was a bit too hastily removed in #247. It's worth keeping
around for now as it handles the variable sizes of SEC-1 keys.
tarcieri added a commit to RustCrypto/signatures that referenced this pull request Aug 4, 2020
Uses the new `FromBytes` trait introduced in RustCrypto/traits#247
tarcieri added a commit to RustCrypto/signatures that referenced this pull request Aug 4, 2020
Uses the new `FromBytes` trait introduced in RustCrypto/traits#247
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 4, 2020
Impls the new `FromBytes`/`ToBytes` traits introduced in
RustCrypto/traits#247
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 4, 2020
Impls the new `FromBytes`/`ToBytes` traits introduced in
RustCrypto/traits#247
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 5, 2020
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247,
and changes `to_bytes()` to return `ElementBytes`.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 5, 2020
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247,
and changes `to_bytes()` to return `ElementBytes`.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 5, 2020
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247,
and changes `to_bytes()` to return `ElementBytes`.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 5, 2020
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247,
and changes `to_bytes()` to return `ElementBytes`.
tarcieri added a commit to RustCrypto/elliptic-curves that referenced this pull request Aug 5, 2020
Impls the new `FromBytes` traits introduced in RustCrypto/traits#247,
and changes `to_bytes()` to return `ElementBytes`.
dns2utf8 pushed a commit to dns2utf8/traits that referenced this pull request Jan 24, 2023
- Change ParamsBuilder to make it more ergonomic
- Remove unnecessary suppressions of dead code warnings
- Fix wrong docs for m_cost
- Fix wrong doc for Block
- Merge `Argon2` and `Instance` structs, remove Memory
- Remove parallel feature (to be re-added)
dns2utf8 pushed a commit to dns2utf8/traits that referenced this pull request Jan 24, 2023
- Bump version to `0.5.0-pre` (RustCrypto#247 contained breaking changes)
- Use pointer casts to convert `Block` integer array to byte array
- Rename `permutate!` to `permute!` (former isn't in OED, latter is)
scv35 added a commit to scv35/Signature-algorithms that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants