enable empty nameId when wantNameId is false #577
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are facing issues when our IP sends empty nameId. There is no reason to throw Exception when I set setting wantNameId as false. Disabling _strict is not good way, I thing. Thank you!
Contributor
|
What IdP are you using? If the NameId element is defined in the SAMLResponse, its value should not be empty. |
Author
|
Unfortunately, this is the subject of a philosophical question.
My IdP strictly binds NameId to email. In some special justified cases user has not email filled.
For our use case it would be OK, to have empty NameId and read another data from atributes.
I know, without NameId user cannot logout, but i tis not needed.
Why Toolkit disables use empty NameId, but omitted NameId is all right? Don’t understand.
Thank for our help
Milan Tůma
From: Sixto Martin ***@***.***>
Sent: Friday, April 26, 2024 9:16 PM
To: SAML-Toolkits/php-saml ***@***.***>
Cc: Tůma Milan ***@***.***>; Author ***@***.***>
Subject: Re: [SAML-Toolkits/php-saml] enable empty nameId when wantNameId is false (PR #577)
What IdP are you using? If the NameId element is defined in the SAMLResponse, its value should not be empty.
—
Reply to this email directly, view it on GitHub<#577 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AP3E77ZGXKXBGRGXHEXRSNTY7KRYLAVCNFSM6AAAAABESTZYROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZHE4DKOJSGY>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
pitbulk
added a commit
that referenced
this pull request
May 13, 2024
Contributor
|
Fair. Fixed here: 2cc0576 |
Author
|
Thank you very much!
From: Sixto Martin ***@***.***>
Sent: Monday, May 13, 2024 1:14 PM
To: SAML-Toolkits/php-saml ***@***.***>
Cc: Tůma Milan ***@***.***>; Author ***@***.***>
Subject: Re: [SAML-Toolkits/php-saml] enable empty nameId when wantNameId is false (PR #577)
Fair. Fixed here: 2cc0576<2cc0576>
—
Reply to this email directly, view it on GitHub<#577 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AP3E772HI4XHEYCIE2A33VTZCCN75AVCNFSM6AAAAABESTZYROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXGI4TSOJQGY>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are facing issues when our IP sends empty nameId. There is no reason to throw Exception when I set setting wantNameId as false. Disabling _strict is not good way, I thing. Thank you!