Skip to content

Comments

[update] version 24.12.10#160

Merged
trirt96 merged 11 commits intomainfrom
241210_update
Dec 23, 2025
Merged

[update] version 24.12.10#160
trirt96 merged 11 commits intomainfrom
241210_update

Conversation

@trirt96
Copy link
Collaborator

@trirt96 trirt96 commented Dec 22, 2025

No description provided.

@trirt96 trirt96 requested a review from a team as a code owner December 22, 2025 10:47
@cla-assistant
Copy link

cla-assistant bot commented Dec 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ trirt96
❌ sap-rahul
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant
Copy link

cla-assistant bot commented Dec 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ trirt96
❌ sap-rahul
You have signed the CLA already but the status is still pending? Let us recheck it.

@trirt96 trirt96 requested a review from serajahmad01 December 22, 2025 10:51
Copy link
Collaborator

@MarcoEidinger MarcoEidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that
Screenshot 2025-12-22 at 8 40 33 AM

but CI build for 24.12.9 succeeds. However, different Xcode version and iOS SDK are being used. Maybe there is a slight difference in workflow handnling when running from PR vs. main branch

Screenshot 2025-12-22 at 8 41 50 AM

Anyway, the download of frameworks works so that looks good. Hence approving it.

Screenshot 2025-12-22 at 8 40 27 AM

@serajahmad01 you might want to change to use -destination "generic/platform=iOS Simulator" for

xcodebuild -workspace TestApp.xcworkspace -scheme 'TestApp' -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 16' clean build
so that issues with non-installed Simulator versions can be avoided.

@trirt96
Copy link
Collaborator Author

trirt96 commented Dec 23, 2025

Thanks for catching the issue in the ci.yml, I’m going to close this PR. i will ask seraj to address the CI failure separately.

@trirt96 trirt96 merged commit 8599ee7 into main Dec 23, 2025
1 of 3 checks passed
@serajahmad01 serajahmad01 deleted the 241210_update branch January 13, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants