Missing check on COLLECT

[suynwa]

Check Name

Missing check on COLLECT

Actual Behavior
Not relevant

Expected Behavior
I could not find any check in the standard ATC w.r.t usage of the COLLECT statement. As per the standard SAP programming guideline , COLLECT should not be used on standard tables anymore.

Do you think it makes sense to implement such a check in Code-Pal?

[lucasborin]

@suynwa : I created a new check under the new_check_collect branch. Would you mind testing it?

[lucasborin]

Known GAPs:

• COLLECT in Internal tables typed as table types (DDIC)
• COLLECT in internal tables that use header lines

EDIT: Solved.

[lucasborin]

Should we apply this rule if the internal table is typed as RANGE OF ...?

    DATA  gr_tabname  TYPE RANGE OF tabname,  "structures and database tables
    ....
    COLLECT ls_tabname INTO gr_tabname.

[suynwa]

Should we apply this rule if the internal table is typed as RANGE OF ...?

Why would someone want to use COLLECT on ranges🤦‍♂️? Maybe to make the check fool-proof we can extend this rule for ranges.

Btw, aren't ranges special type of standard tables? What info does RTTI return for ranges?

[lucasborin]

Yes, they are. The documentation says:

A ranges table is a standard table with a standard key

So, I would say the COLLECT on RANGES is not valid anymore.

What info does RTTI return for ranges?

TYPES: BEGIN OF linetype,
         sign   TYPE c LENGTH 1,
         option TYPE c LENGTH 2,
         low    {TYPE type}|{LIKE dobj},
         high   {TYPE type}|{LIKE dobj},
       END OF linetype.

[lucasborin]

How about this?

  DATA: BEGIN OF lt_bukrs OCCURS 0,
          bukrs         LIKE j_1bnfdoc-bukrs,
        END OF lt_bukrs,

  LOOP AT ti_list.
    MOVE ti_list-bukrs TO lt_bukrs.
    COLLECT lt_bukrs.
  ENDLOOP.