Fix an inappropriate test expression to remove a logical short circuit

[munahaf]

In file: processor.py, the comparison of Collection length creates a logical short circuit. The length of a collection is always greater than or equal to zero. So testing that a length is less than zero is always false.

I suggested that the Collection length comparison should be done without creating a logical short circuit.

Sponsorship and Support:

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

[heinezen]

Thanks for the fix. Can you do the following before we merge this?

• You need to add your name to the copying.md file
• Can you change the check to len(upgrade_effects) == 0? While this is considered unpythonic by some, it makes the check more readable.

[TheJJ]

the commit for your authorship isn't pushed to this pull request's branch yet.

[heinezen]

Do you need help with any of this?

[heinezen]

I've cherry picked your commit and added it to the correct branch. It should be mergeable now.