Fix bugs + add more tests

src/lib/migrations/MigrationRecordBuilder.php

@@ -34,12 +34,12 @@ final class MigrationRecordBuilder
     public const ADD_PK = MigrationRecordBuilder::INDENT . "\$this->addPrimaryKey('%s', '%s', '%s');";
     public const ADD_COLUMN = MigrationRecordBuilder::INDENT . "\$this->addColumn('%s', '%s', %s);";
 
-    public const ADD_COLUMN_RAW = MigrationRecordBuilder::INDENT . "\$this->db->createCommand(\"ALTER TABLE %s ADD COLUMN %s %s\")->execute();";
+    public const ADD_COLUMN_RAW = MigrationRecordBuilder::INDENT . "\$this->db->createCommand('ALTER TABLE %s ADD COLUMN %s %s')->execute();";
 
     public const ALTER_COLUMN = MigrationRecordBuilder::INDENT . "\$this->alterColumn('%s', '%s', %s);";
 
-    public const ALTER_COLUMN_RAW = MigrationRecordBuilder::INDENT . "\$this->db->createCommand(\"ALTER TABLE %s MODIFY %s %s\")->execute();";
-    public const ALTER_COLUMN_RAW_PGSQL = MigrationRecordBuilder::INDENT . "\$this->db->createCommand(\"ALTER TABLE %s ALTER COLUMN %s SET DATA TYPE %s\")->execute();";
+    public const ALTER_COLUMN_RAW = MigrationRecordBuilder::INDENT . "\$this->db->createCommand('ALTER TABLE %s MODIFY %s %s')->execute();";
+    public const ALTER_COLUMN_RAW_PGSQL = MigrationRecordBuilder::INDENT . "\$this->db->createCommand('ALTER TABLE %s ALTER COLUMN %s SET DATA TYPE %s')->execute();";
 
     /**
      * @var \yii\db\Schema

tests/specs/x_db_type/edit_column/maria/app/migrations_maria_db/m200000_000001_change_table_editcolumns.php

@@ -7,9 +7,9 @@ class m200000_000001_change_table_editcolumns extends \yii\db\Migration
 {
     public function up()
     {
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ADD COLUMN first_name varchar(255) NULL DEFAULT NULL")->execute();
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n json NOT NULL DEFAULT \'[]\'")->execute();
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n_2 json NOT NULL DEFAULT \'[]\'")->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN first_name varchar(255) NULL DEFAULT NULL')->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n json NOT NULL DEFAULT \'[]\'')->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n_2 json NOT NULL DEFAULT \'[]\'')->execute();
         $this->alterColumn('{{%editcolumns}}', 'dec_col', $this->decimal(12,2)->null()->defaultValue("3.14"));
         $this->alterColumn('{{%editcolumns}}', 'json_col', $this->text()->notNull()->defaultValue("fox jumps over dog"));
         $this->alterColumn('{{%editcolumns}}', 'json_col_2', 'json NOT NULL DEFAULT \'[]\'');

tests/specs/x_db_type/edit_column/mysql/app/migrations_mysql_db/m200000_000001_change_table_editcolumns.php

@@ -7,9 +7,9 @@ class m200000_000001_change_table_editcolumns extends \yii\db\Migration
 {
     public function up()
     {
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ADD COLUMN first_name varchar(255) NULL DEFAULT NULL")->execute();
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n json NOT NULL")->execute();
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n_2 json NOT NULL")->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN first_name varchar(255) NULL DEFAULT NULL')->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n json NOT NULL')->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n_2 json NOT NULL')->execute();
         $this->alterColumn('{{%editcolumns}}', 'dec_col', $this->decimal(12,2)->null()->defaultValue("3.14"));
         $this->alterColumn('{{%editcolumns}}', 'json_col', $this->text()->notNull());
         $this->alterColumn('{{%editcolumns}}', 'json_col_2', 'json NOT NULL');

tests/specs/x_db_type/edit_column/pgsql/app/migrations_pgsql_db/m200000_000000_create_table_alldbdatatypes.php

@@ -12,95 +12,96 @@ public function safeUp()
             0 => 'string_col varchar NULL DEFAULT NULL',
             1 => 'varchar_col varchar NULL DEFAULT NULL',
             2 => 'text_col text NULL DEFAULT NULL',
-            3 => 'varchar_4_col varchar(4) NULL DEFAULT NULL',
-            4 => 'varchar_5_col varchar(5) NULL DEFAULT NULL',
-            5 => 'char_4_col char(4) NULL DEFAULT NULL',
-            6 => 'char_5_col char NULL DEFAULT NULL',
-            7 => 'char_6_col char NOT NULL',
-            8 => 'char_7_col char(6) NOT NULL',
-            9 => 'char_8_col char NULL DEFAULT \'d\'',
-            10 => 'decimal_col decimal(12,3) NULL DEFAULT NULL',
-            11 => 'bytea_col_2 bytea NULL DEFAULT NULL',
-            12 => 'bit_col bit NULL DEFAULT NULL',
-            13 => 'bit_2 bit(1) NULL DEFAULT NULL',
-            14 => 'bit_3 bit(64) NULL DEFAULT NULL',
-            15 => 'ti smallint NULL DEFAULT NULL',
-            16 => 'int2_col int2 NULL DEFAULT NULL',
-            17 => 'smallserial_col smallserial NOT NULL',
-            18 => 'serial2_col serial2 NOT NULL',
-            19 => 'si_col smallint NULL DEFAULT NULL',
-            20 => 'si_col_2 smallint NULL DEFAULT NULL',
-            21 => 'bi bigint NULL DEFAULT NULL',
-            22 => 'bi2 int8 NULL DEFAULT NULL',
-            23 => 'int4_col int4 NULL DEFAULT NULL',
-            24 => 'bigserial_col bigserial NOT NULL',
-            25 => 'bigserial_col_2 serial8 NOT NULL',
-            26 => 'int_col int NULL DEFAULT NULL',
-            27 => 'int_col_2 integer NULL DEFAULT NULL',
-            28 => 'numeric_col numeric NULL DEFAULT NULL',
-            29 => 'numeric_col_2 numeric(10) NULL DEFAULT NULL',
-            30 => 'numeric_col_3 numeric(10,2) NULL DEFAULT NULL',
-            31 => 'double_p_2 double precision NULL DEFAULT NULL',
-            32 => 'double_p_3 double precision NULL DEFAULT NULL',
-            33 => 'real_col real NULL DEFAULT NULL',
-            34 => 'float4_col float4 NULL DEFAULT NULL',
-            35 => 'date_col date NULL DEFAULT NULL',
-            36 => 'time_col time NULL DEFAULT NULL',
-            37 => 'time_col_2 time with time zone NULL DEFAULT NULL',
-            38 => 'time_col_3 time without time zone NULL DEFAULT NULL',
-            39 => 'time_col_4 time(3) without time zone NULL DEFAULT NULL',
-            40 => 'timetz_col timetz NULL DEFAULT NULL',
-            41 => 'timetz_col_2 timetz(3) NULL DEFAULT NULL',
-            42 => 'timestamp_col timestamp NULL DEFAULT NULL',
-            43 => 'timestamp_col_2 timestamp with time zone NULL DEFAULT NULL',
-            44 => 'timestamp_col_3 timestamp without time zone NULL DEFAULT NULL',
-            45 => 'timestamp_col_4 timestamp(3) without time zone NULL DEFAULT NULL',
-            46 => 'timestamptz_col timestamptz NULL DEFAULT NULL',
-            47 => 'timestamptz_col_2 timestamptz(3) NULL DEFAULT NULL',
-            48 => 'date2 date NULL DEFAULT NULL',
-            49 => 'timestamp_col_z timestamp NULL DEFAULT NULL',
-            50 => 'bit_varying bit varying NULL DEFAULT NULL',
-            51 => 'bit_varying_n bit varying(8) NULL DEFAULT NULL',
-            52 => 'bit_varying_n_2 varbit NULL DEFAULT NULL',
-            53 => 'bit_varying_n_3 varbit(3) NULL DEFAULT NULL',
-            54 => 'bool_col boolean NULL DEFAULT NULL',
-            55 => 'bool_col_2 bool NULL DEFAULT NULL',
-            56 => 'box_col box NULL DEFAULT NULL',
-            57 => 'character_col character NULL DEFAULT NULL',
-            58 => 'character_n character(12) NULL DEFAULT NULL',
-            59 => 'character_varying character varying NULL DEFAULT NULL',
-            60 => 'character_varying_n character varying(12) NULL DEFAULT NULL',
-            61 => 'json_col json NOT NULL',
-            62 => 'jsonb_col jsonb NOT NULL',
-            63 => 'json_col_def json NOT NULL DEFAULT \'[]\'',
-            64 => 'json_col_def_2 json NOT NULL DEFAULT \'[]\'',
-            65 => 'bytea_def bytea NULL DEFAULT \'the bytea blob default\'',
-            66 => 'text_def text NULL DEFAULT \'the text\'',
-            67 => 'json_def json NOT NULL DEFAULT \'{"a":"b"}\'',
-            68 => 'jsonb_def jsonb NOT NULL DEFAULT \'{"ba":"bb"}\'',
-            69 => 'cidr_col cidr NULL DEFAULT NULL',
-            70 => 'circle_col circle NULL DEFAULT NULL',
-            71 => 'date_col_z date NULL DEFAULT NULL',
-            72 => 'float8_col float8 NULL DEFAULT NULL',
-            73 => 'inet_col inet NULL DEFAULT NULL',
-            74 => 'interval_col interval NULL DEFAULT NULL',
-            75 => 'interval_col_2 interval year NULL DEFAULT NULL',
-            76 => 'interval_col_3 interval day to second(3) NULL DEFAULT NULL',
-            77 => 'line_col line NULL DEFAULT NULL',
-            78 => 'lseg_col lseg NULL DEFAULT NULL',
-            79 => 'macaddr_col macaddr NULL DEFAULT NULL',
-            80 => 'money_col money NULL DEFAULT NULL',
-            81 => 'path_col path NULL DEFAULT NULL',
-            82 => 'pg_lsn_col pg_lsn NULL DEFAULT NULL',
-            83 => 'point_col point NULL DEFAULT NULL',
-            84 => 'polygon_col polygon NULL DEFAULT NULL',
-            85 => 'serial_col serial NOT NULL',
-            86 => 'serial4_col serial4 NOT NULL',
-            87 => 'tsquery_col tsquery NULL DEFAULT NULL',
-            88 => 'tsvector_col tsvector NULL',
-            89 => 'txid_snapshot_col txid_snapshot NULL DEFAULT NULL',
-            90 => 'uuid_col uuid NULL DEFAULT NULL',
-            91 => 'xml_col xml NULL DEFAULT NULL',
+            3 => 'text_col_array text[] NULL DEFAULT NULL',
+            4 => 'varchar_4_col varchar(4) NULL DEFAULT NULL',
+            5 => 'varchar_5_col varchar(5) NULL DEFAULT NULL',
+            6 => 'char_4_col char(4) NULL DEFAULT NULL',
+            7 => 'char_5_col char NULL DEFAULT NULL',
+            8 => 'char_6_col char NOT NULL',
+            9 => 'char_7_col char(6) NOT NULL',
+            10 => 'char_8_col char NULL DEFAULT \'d\'',
+            11 => 'decimal_col decimal(12,3) NULL DEFAULT NULL',
+            12 => 'bytea_col_2 bytea NULL DEFAULT NULL',
+            13 => 'bit_col bit NULL DEFAULT NULL',
+            14 => 'bit_2 bit(1) NULL DEFAULT NULL',
+            15 => 'bit_3 bit(64) NULL DEFAULT NULL',
+            16 => 'ti smallint NULL DEFAULT NULL',
+            17 => 'int2_col int2 NULL DEFAULT NULL',
+            18 => 'smallserial_col smallserial NOT NULL',
+            19 => 'serial2_col serial2 NOT NULL',
+            20 => 'si_col smallint NULL DEFAULT NULL',
+            21 => 'si_col_2 smallint NULL DEFAULT NULL',
+            22 => 'bi bigint NULL DEFAULT NULL',
+            23 => 'bi2 int8 NULL DEFAULT NULL',
+            24 => 'int4_col int4 NULL DEFAULT NULL',
+            25 => 'bigserial_col bigserial NOT NULL',
+            26 => 'bigserial_col_2 serial8 NOT NULL',
+            27 => 'int_col int NULL DEFAULT NULL',
+            28 => 'int_col_2 integer NULL DEFAULT NULL',
+            29 => 'numeric_col numeric NULL DEFAULT NULL',
+            30 => 'numeric_col_2 numeric(10) NULL DEFAULT NULL',
+            31 => 'numeric_col_3 numeric(10,2) NULL DEFAULT NULL',
+            32 => 'double_p_2 double precision NULL DEFAULT NULL',
+            33 => 'double_p_3 double precision NULL DEFAULT NULL',
+            34 => 'real_col real NULL DEFAULT NULL',
+            35 => 'float4_col float4 NULL DEFAULT NULL',
+            36 => 'date_col date NULL DEFAULT NULL',
+            37 => 'time_col time NULL DEFAULT NULL',
+            38 => 'time_col_2 time with time zone NULL DEFAULT NULL',
+            39 => 'time_col_3 time without time zone NULL DEFAULT NULL',
+            40 => 'time_col_4 time(3) without time zone NULL DEFAULT NULL',
+            41 => 'timetz_col timetz NULL DEFAULT NULL',
+            42 => 'timetz_col_2 timetz(3) NULL DEFAULT NULL',
+            43 => 'timestamp_col timestamp NULL DEFAULT NULL',
+            44 => 'timestamp_col_2 timestamp with time zone NULL DEFAULT NULL',
+            45 => 'timestamp_col_3 timestamp without time zone NULL DEFAULT NULL',
+            46 => 'timestamp_col_4 timestamp(3) without time zone NULL DEFAULT NULL',
+            47 => 'timestamptz_col timestamptz NULL DEFAULT NULL',
+            48 => 'timestamptz_col_2 timestamptz(3) NULL DEFAULT NULL',
+            49 => 'date2 date NULL DEFAULT NULL',
+            50 => 'timestamp_col_z timestamp NULL DEFAULT NULL',
+            51 => 'bit_varying bit varying NULL DEFAULT NULL',
+            52 => 'bit_varying_n bit varying(8) NULL DEFAULT NULL',
+            53 => 'bit_varying_n_2 varbit NULL DEFAULT NULL',
+            54 => 'bit_varying_n_3 varbit(3) NULL DEFAULT NULL',
+            55 => 'bool_col boolean NULL DEFAULT NULL',
+            56 => 'bool_col_2 bool NULL DEFAULT NULL',
+            57 => 'box_col box NULL DEFAULT NULL',
+            58 => 'character_col character NULL DEFAULT NULL',
+            59 => 'character_n character(12) NULL DEFAULT NULL',
+            60 => 'character_varying character varying NULL DEFAULT NULL',
+            61 => 'character_varying_n character varying(12) NULL DEFAULT NULL',
+            62 => 'json_col json NOT NULL',
+            63 => 'jsonb_col jsonb NOT NULL',
+            64 => 'json_col_def json NOT NULL DEFAULT \'[]\'',
+            65 => 'json_col_def_2 json NOT NULL DEFAULT \'[]\'',
+            66 => 'bytea_def bytea NULL DEFAULT \'the bytea blob default\'',
+            67 => 'text_def text NULL DEFAULT \'the text\'',
+            68 => 'json_def json NOT NULL DEFAULT \'{"a":"b"}\'',
+            69 => 'jsonb_def jsonb NOT NULL DEFAULT \'{"ba":"bb"}\'',
+            70 => 'cidr_col cidr NULL DEFAULT NULL',
+            71 => 'circle_col circle NULL DEFAULT NULL',
+            72 => 'date_col_z date NULL DEFAULT NULL',
+            73 => 'float8_col float8 NULL DEFAULT NULL',
+            74 => 'inet_col inet NULL DEFAULT NULL',
+            75 => 'interval_col interval NULL DEFAULT NULL',
+            76 => 'interval_col_2 interval year NULL DEFAULT NULL',
+            77 => 'interval_col_3 interval day to second(3) NULL DEFAULT NULL',
+            78 => 'line_col line NULL DEFAULT NULL',
+            79 => 'lseg_col lseg NULL DEFAULT NULL',
+            80 => 'macaddr_col macaddr NULL DEFAULT NULL',
+            81 => 'money_col money NULL DEFAULT NULL',
+            82 => 'path_col path NULL DEFAULT NULL',
+            83 => 'pg_lsn_col pg_lsn NULL DEFAULT NULL',
+            84 => 'point_col point NULL DEFAULT NULL',
+            85 => 'polygon_col polygon NULL DEFAULT NULL',
+            86 => 'serial_col serial NOT NULL',
+            87 => 'serial4_col serial4 NOT NULL',
+            88 => 'tsquery_col tsquery NULL DEFAULT NULL',
+            89 => 'tsvector_col tsvector NULL',
+            90 => 'txid_snapshot_col txid_snapshot NULL DEFAULT NULL',
+            91 => 'uuid_col uuid NULL DEFAULT NULL',
+            92 => 'xml_col xml NULL DEFAULT NULL',
         ]);
     }
 

tests/specs/x_db_type/edit_column/pgsql/app/migrations_pgsql_db/m200000_000001_change_table_editcolumns.php

@@ -7,18 +7,19 @@ class m200000_000001_change_table_editcolumns extends \yii\db\Migration
 {
     public function safeUp()
     {
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ADD COLUMN first_name varchar NULL DEFAULT NULL")->execute();
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n json NOT NULL DEFAULT \'[]\'")->execute();
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n_2 json NOT NULL DEFAULT \'[]\'")->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN first_name varchar NULL DEFAULT NULL')->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n json NOT NULL DEFAULT \'[]\'')->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n_2 json NOT NULL DEFAULT \'[]\'')->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN text_col_array text[] NULL DEFAULT NULL')->execute();
         $this->alterColumn('{{%editcolumns}}', 'dec_col', "SET DEFAULT 3.14");
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ALTER COLUMN json_col SET DATA TYPE text")->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ALTER COLUMN json_col SET DATA TYPE text')->execute();
         $this->alterColumn('{{%editcolumns}}', 'json_col', "SET NOT NULL");
         $this->alterColumn('{{%editcolumns}}', 'json_col', "SET DEFAULT 'fox jumps over dog'");
         $this->alterColumn('{{%editcolumns}}', 'json_col_2', "SET NOT NULL");
         $this->alterColumn('{{%editcolumns}}', 'json_col_2', "SET DEFAULT '[]'");
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ALTER COLUMN name SET DATA TYPE varchar(254)")->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ALTER COLUMN name SET DATA TYPE varchar(254)')->execute();
         $this->alterColumn('{{%editcolumns}}', 'name', "SET DEFAULT 'Horse-2'");
-        $this->db->createCommand("ALTER TABLE {{%editcolumns}} ALTER COLUMN numeric_col SET DATA TYPE double precision")->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ALTER COLUMN numeric_col SET DATA TYPE double precision')->execute();
         $this->alterColumn('{{%editcolumns}}', 'str_col_def', "SET NOT NULL");
         $this->alterColumn('{{%editcolumns}}', 'str_col_def', "DROP DEFAULT");
         $this->alterColumn('{{%editcolumns}}', 'string_col', $this->text()->null());
@@ -31,6 +32,7 @@ public function safeDown()
         $this->alterColumn('{{%editcolumns}}', 'numeric_col', 'int4 NULL USING "numeric_col"::int4');
         $this->alterColumn('{{%editcolumns}}', 'name', $this->string(255)->notNull());
         $this->alterColumn('{{%editcolumns}}', 'json_col', 'jsonb NULL USING "json_col"::jsonb');
+        $this->dropColumn('{{%editcolumns}}', 'text_col_array');
         $this->dropColumn('{{%editcolumns}}', 'json_col_def_n_2');
         $this->dropColumn('{{%editcolumns}}', 'json_col_def_n');
         $this->dropColumn('{{%editcolumns}}', 'first_name');

tests/specs/x_db_type/edit_column/pgsql/app/migrations_pgsql_db/m200000_000002_create_table_newcolumns.php

@@ -18,6 +18,7 @@ public function safeUp()
             5 => 'numeric_col double precision NULL DEFAULT NULL',
             6 => 'json_col_def_n json NOT NULL DEFAULT \'[]\'',
             7 => 'json_col_def_n_2 json NOT NULL DEFAULT \'[]\'',
+            8 => 'text_col_array text[] NULL DEFAULT NULL',
         ]);
     }