Fix bug in column change detection in Pgsql

src/lib/migrations/MysqlMigrationBuilder.php

@@ -120,7 +120,7 @@ public function modifyCurrent(ColumnSchema $current): void
             $current->defaultValue = (int)$current->defaultValue;
         }
 
-        // TODO this is not concretely correct
+        // TODO this is not concretely correct, reason is in BaseMigrationBuilder
         if (!empty($current->enumValues)) {
             $current->type = 'enum';
             $current->dbType = 'enum';
@@ -139,7 +139,7 @@ public function modifyDesired(ColumnSchema $desired): void
             $desired->scale = $decimalAttributes['scale'];
         }
 
-        // TODO this is not concretely correct
+        // TODO this is not concretely correct, reason is in BaseMigrationBuilder
         if (!empty($desired->enumValues)) {
             $desired->type = 'enum';
             $desired->dbType = 'enum';

src/lib/migrations/PostgresMigrationBuilder.php

@@ -63,7 +63,10 @@ protected function buildColumnChanges(ColumnSchema $current, ColumnSchema $desir
             return;
         }
 
-        if (!empty(array_intersect(['type', 'size'/*, 'dbType'*/], $changed))) {
+        if (!empty(array_intersect(['type', 'size'
+                    , 'dbType', 'phpType'
+                    , 'precision', 'scale', 'unsigned'
+        ], $changed))) {
             $addUsing = $this->isNeedUsingExpression($desired->type, $current->type);
             $this->migration->addUpCode($this->recordBuilder->alterColumnType($tableName, $desired));
             $this->migration->addDownCode($this->recordBuilder->alterColumnTypeFromDb($tableName, $current, $addUsing));
@@ -207,7 +210,7 @@ public function modifyCurrent(ColumnSchema $current): void
         if ($current->phpType === 'integer' && $current->defaultValue !== null) {
             $current->defaultValue = (int)$current->defaultValue;
         }
-        // TODO this is not concretely correct
+        // TODO this is not concretely correct, reason is in BaseMigrationBuilder
         if (!empty($current->enumValues)) {
             $current->type = 'enum';
             $current->dbType = 'enum';
@@ -224,7 +227,7 @@ public function modifyDesired(ColumnSchema $desired): void
             $desired->precision = $decimalAttributes['precision'];
             $desired->scale = $decimalAttributes['scale'];
         }
-        // TODO this is not concretely correct
+        // TODO this is not concretely correct, reason is in BaseMigrationBuilder
         if (!empty($desired->enumValues)) {
             $desired->type = 'enum';
             $desired->dbType = 'enum';

tests/specs/postgres_custom.yaml

@@ -48,21 +48,21 @@ components:
                     default: 0
                 json1:
                     type: array
-                    x-db-type: json
+                    x-db-type: jsonb
                     default: []
                 json2:
                     type: array
-                    x-db-type: json
+                    x-db-type: jsonb
                     default: '{}'
                 json3:
                     type: array
-                    x-db-type: json
+                    x-db-type: jsonb
                     default:
                         - foo: foobar
                         - xxx: yyy
                 json4:
                     type: array
-                    x-db-type: json
+                    x-db-type: jsonb
                     default: '{"foo": "bar", "bar": "baz"}'
                 # status:
                 #     type: string

tests/specs/x_db_type/edit_column/pgsql/app/migrations_pgsql_db/m200000_000001_change_table_editcolumns.php

@@ -11,6 +11,7 @@ public function safeUp()
         $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n json NOT NULL DEFAULT \'[]\'')->execute();
         $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN json_col_def_n_2 json NOT NULL DEFAULT \'[]\'')->execute();
         $this->db->createCommand('ALTER TABLE {{%editcolumns}} ADD COLUMN text_col_array text[] NULL DEFAULT NULL')->execute();
+        $this->db->createCommand('ALTER TABLE {{%editcolumns}} ALTER COLUMN dec_col SET DATA TYPE decimal(12,2)')->execute();
         $this->alterColumn('{{%editcolumns}}', 'dec_col', "SET DEFAULT 3.14");
         $this->db->createCommand('ALTER TABLE {{%editcolumns}} ALTER COLUMN json_col SET DATA TYPE text')->execute();
         $this->alterColumn('{{%editcolumns}}', 'json_col', "SET NOT NULL");
@@ -32,6 +33,7 @@ public function safeDown()
         $this->alterColumn('{{%editcolumns}}', 'numeric_col', 'int4 NULL USING "numeric_col"::int4');
         $this->alterColumn('{{%editcolumns}}', 'name', $this->string(255)->notNull());
         $this->alterColumn('{{%editcolumns}}', 'json_col', 'jsonb NULL USING "json_col"::jsonb');
+        $this->alterColumn('{{%editcolumns}}', 'dec_col', $this->decimal()->null());
         $this->dropColumn('{{%editcolumns}}', 'text_col_array');
         $this->dropColumn('{{%editcolumns}}', 'json_col_def_n_2');
         $this->dropColumn('{{%editcolumns}}', 'json_col_def_n');

tests/specs/x_db_type/fresh/pgsql/x_db_type_pgsql.yaml

@@ -505,7 +505,7 @@ components:
           default: fox jumps over dog
         json_col_2:
           type: string
-          x-db-type: json
+          x-db-type: jsonb
           nullable: false
           default: []
         numeric_col:

tests/unit/XDbTypeTest.php

@@ -197,7 +197,7 @@ private function createTableForEditColumns()
             'string_col' => 'string not null',
             'dec_col' => 'decimal(12, 4)',
             'str_col_def' => 'string default \'hi there\'',
-            'json_col' => 'json',
+            'json_col' => 'json', // json is jsonb in Pgsql via Yii Pgsql Schema
             'json_col_2' => 'json',
             'numeric_col' => 'integer',
         ])->execute();