Skip to content

Fix 104- Remove id from rules() method from base model during code generation #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SOHELAHMED7 merged 9 commits into from
Dec 30, 2022
Merged

Fix 104- Remove id from rules() method from base model during code generation #4

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
20e960a
test to trigger CI
SOHELAHMED7 Dec 29, 2022
4066e93
test to trigger CI 2
SOHELAHMED7 Dec 29, 2022
ca72322
test to trigger CI 3
SOHELAHMED7 Dec 29, 2022
672ae45
test to trigger CI 4
SOHELAHMED7 Dec 29, 2022
7da7317
Fix style
SOHELAHMED7 Dec 29, 2022
53d4de4
test to trigger CI 5
SOHELAHMED7 Dec 29, 2022
0041f7b
Fix style
SOHELAHMED7 Dec 29, 2022
a2d0c80
Fix https://github.com/cebe/yii2-openapi/issues/104
SOHELAHMED7 Dec 30, 2022
1f1e71f
remove unwanted files
SOHELAHMED7 Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix style
  • Loading branch information
@SOHELAHMED7
SOHELAHMED7 committed Dec 29, 2022
commit 0041f7b7418b5f1283fde5fd206dda218812caf4
4 changes: 1 addition & 3 deletions src/lib/migrations/BaseMigrationBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,8 +482,7 @@ public static function isEnumValuesChanged(
public function isDefaultValueChanged(
ColumnSchema $current,
ColumnSchema $desired
): bool
{
): bool {
// if the default value is object of \yii\db\Expression then default value is expression instead of constant. See https://dev.mysql.com/doc/refman/8.0/en/data-type-defaults.html
// in such case instead of comparing two objects, we should compare expression

Expand All @@ -500,4 +499,3 @@ public function isDefaultValueChanged(
return false;
}
}