Skip to content

Resolve - Fix issue - Quote issue to preserve the case of the column name #127 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SOHELAHMED7 merged 4 commits into from
Jan 3, 2023
Merged

Resolve - Fix issue - Quote issue to preserve the case of the column name #127 #9

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e341e9
Initial commit of this branch
SOHELAHMED7 Jan 2, 2023
4da1db2
Fix https://github.com/cebe/yii2-openapi/issues/127
SOHELAHMED7 Jan 2, 2023
2f58a9e
Fix quote issue in enum in PgSQL
SOHELAHMED7 Jan 2, 2023
e8f1df1
Fix quote issue in enum in PgSQL 2
SOHELAHMED7 Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix quote issue in enum in PgSQL 2
  • Loading branch information
@SOHELAHMED7
SOHELAHMED7 committed Jan 2, 2023
commit e8f1df1d8ad60dd5f2eff8379157ada441defc50
4 changes: 2 additions & 2 deletions src/lib/migrations/BaseMigrationBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ public function tmpSaveNewCol(\cebe\yii2openapi\db\ColumnSchema $columnSchema):
{
$tableName = 'tmp_table_';
$tmpEnumName = function (string $columnName): string {
return 'tmp_enum_'.$columnName.'_';
return '"tmp_enum_'.$columnName.'_"';
};

Yii::$app->db->createCommand('DROP TABLE IF EXISTS '.$tableName)->execute();
Expand Down Expand Up @@ -455,7 +455,7 @@ public function tmpSaveNewCol(\cebe\yii2openapi\db\ColumnSchema $columnSchema):

if (ApiGenerator::isPostgres() && static::isEnum($columnSchema)) {// drop enum
Yii::$app->db->createCommand('DROP TYPE '.$tmpEnumName($columnSchema->name))->execute();
if ($table->columns[$columnSchema->name]->dbType !== $tmpEnumName($columnSchema->name)) {
if ('"'.$table->columns[$columnSchema->name]->dbType.'"' !== $tmpEnumName($columnSchema->name)) {
throw new \Exception('Unknown error related to PgSQL enum '.$table->columns[$columnSchema->name]->dbType);
}
// reset back column enum name to original as we are comparing with current
Expand Down