Skip to content

Upgrade Carbon Factory from v5.0.0 to v5.2.1 #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianoxley merged 6 commits into from
Sep 12, 2018
Merged

Upgrade Carbon Factory from v5.0.0 to v5.2.1 #1836

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b661f64
Upgrade carbon-factory to v5.1.0
ianoxley Sep 10, 2018
4a5f7c1
Fix failing router test after Jest update
ianoxley Sep 10, 2018
3151b98
Upgrade carbon-factory from v5.1.0 to v5.2.0
ianoxley Sep 10, 2018
927311f
Upgrade carbon-factory from v5.2.0 to v5.2.1
ianoxley Sep 10, 2018
27a1a11
Add release notes
ianoxley Sep 10, 2018
2eefebe
Merge branch 'master' into cf-upgrades-v5.2.1
ianoxley Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix failing router test after Jest update 
A Jest bug fix means the default testURL for tests is now
http://localhost instead of `about:blank`. Update the router test args
accordingly.
  • Loading branch information
@ianoxley
ianoxley committed Sep 10, 2018
commit 4a5f7c1636efff6e3eb6183675bb09a2238856e5
4 changes: 3 additions & 1 deletion src/utils/router/__spec__.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ describe('startRouter', () => {

router.props.onUpdate();

// Change last argument to '/' in response to this fix:
// https://github.com/facebook/jest/pull/6792
expect(gaSpy).toHaveBeenCalledWith('set', 'page', '/');
expect(gaSpy).toHaveBeenCalledWith('send', 'pageview');
expect(gaSpy).toHaveBeenCalledWith('set', 'page', 'blank');
});
});

Expand Down