Skip to content

Adjusted how dtors get called on types that don't support non-destructive moves #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SanderMertens merged 9 commits into from
Dec 6, 2025
Merged

Adjusted how dtors get called on types that don't support non-destructive moves #1874

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b5cdbae
Fixed move_dtor not being called when relevant.
Watermelon914 Nov 15, 2025
d3f1300
Adjustments
Watermelon914 Nov 15, 2025
c7d4c1c
Adds distr changes
Watermelon914 Nov 15, 2025
47941d7
Updates distr/flecs.c
Watermelon914 Nov 15, 2025
161aa74
Added some tests + reverted changes to flecs_set_id_move
Watermelon914 Nov 16, 2025
cce1ad1
Comment fixes
Watermelon914 Nov 16, 2025
c265629
Fixes comment
Watermelon914 Nov 16, 2025
d508d55
Fixed distr/flecs.c being out of sync
Watermelon914 Nov 17, 2025
37eb8c2
Undid changes to cpp test
Watermelon914 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Comment fixes
  • Loading branch information
@Watermelon914
Watermelon914 committed Nov 16, 2025
commit cce1ad19d5f5033e0d3ad0c14fde33aeb49b2044
2 changes: 1 addition & 1 deletion test/core/src/ComponentLifecycle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3571,7 +3571,7 @@ void ComponentLifecycle_dtor_on_destructive_component_removal_complex(void) {
test_int(vel_ctx.move_dtor.invoked, 0);
test_int(vel_ctx.dtor.invoked, 0);

// Position should not have any dtors since we haven't
// Position should not have any dtors since we haven't removed/deleted any.
// There should be exactly 1 ctor_move_dtor and 1 dtor,
// as we have deleted Position from e. e3's
test_int(pos_ctx.move_dtor.invoked, 0);
Expand Down
Loading