Skip to content

Conversation

emigun
Copy link
Member

@emigun emigun commented Sep 26, 2025

Description

Fix for bug where pagination for datasets under proposals is broken

Fixes:

Closes #2028

Changes:

  • fetchProposalDatasetsCompleteAction now requires skip and limit
  • reducer stores skip and limit in datasetFilters

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Summary by Sourcery

Fix broken pagination for proposal datasets by tracking and persisting skip and limit parameters throughout actions, reducer, effects, and component

Bug Fixes:

  • Persist skip and limit values to restore pagination state for proposal datasets

Enhancements:

  • Extend fetchProposalDatasets actions to include skip and limit parameters and update reducer to store them in datasetFilters
  • Modify ProposalEffects and ProposalDatasetsComponent to dispatch and handle skip and limit values
  • Update tests across actions, reducer, and effects to cover pagination parameters

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- fetchProposalDatasetsCompleteAction now requires skip and limit
- reducer stores skip and limit in datasetFilters
@emigun emigun force-pushed the fix-proposals-datasets-pagination branch from de9b655 to fc5fb19 Compare September 26, 2025 10:46
@Junjiequan Junjiequan requested a review from a team September 26, 2025 11:36
Copy link
Member

@Junjiequan Junjiequan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@emigun emigun merged commit e13e0a7 into master Sep 26, 2025
13 of 15 checks passed
@emigun emigun deleted the fix-proposals-datasets-pagination branch September 26, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination for datasets under a proposal broken
2 participants