-
-
Notifications
You must be signed in to change notification settings - Fork 81
Reaction complexes v2 #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Complex stoichiometric matrices, reaction rates etc functions
adding some tests for functions related to complex-based matrices of reaction network
export the functions reaction_complexes, reaction_rates, complex_stoich_matrix, complex_incidence_matrix, complex_outgoing_matrix
adding some more tests to see whether Z*B == netstoichmat(rn)'
revising function definitions of complex based representations based
It this looks good to you I'll make some more tweaks and merge if tests pass. |
Hi @isaacsas , Next PRs could involve plotting visualising these complexes on graphs and Loading reaction system based on Z, B matrices as function arguments ? I have small demos of these. |
I think creating a Adding visualization here makes sense. |
@yewalenikhil65 nice job on this one! |
It would also be good to add a new tutorial showing how to use these matrices to do something interesting (maybe once you add the visualization features). |
@isaacsas Thanks sir for your inputs. |
@yewalenikhil65 so as not to pollute your original PR I created a branch off it and made updates. What do you think? The tests you added now all pass for me.