Skip to content

Unit validation and tests #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaacsas merged 5 commits into from
Aug 20, 2021
Merged

Unit validation and tests #381

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70b08d5
update unit validation, check systems, add tests
isaacsas Aug 19, 2021
157cd17
shorten reaction validation a bit
isaacsas Aug 19, 2021
bdf04e6
tweak warning message
isaacsas Aug 19, 2021
b6227a7
tweak ReactionSystem docs
isaacsas Aug 19, 2021
d5d6b29
don't interpolate strings into strings
isaacsas Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweak ReactionSystem docs
  • Loading branch information
@isaacsas
isaacsas committed Aug 19, 2021
commit b6227a77f8c09000e3181cd12899bd9e1745678c
10 changes: 5 additions & 5 deletions src/reactionsystem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ Continuing from the example in the [`Reaction`](@ref) definition:
@named rs = ReactionSystem(rxs, t, [A,B,C,D], k)

Notes:
- ReactionSystems currently do rudimentary unit checking by generating for all
reactions the corresponding ODE rate expressions, and making sure they are
independently self-consistent. Note, this does not check that all the ODE
rate laws actually have the same units, just that they do not involve sums
with differing units.
- ReactionSystems currently do rudimentary unit checking, requiring that
all species have the same units, and all reactions have rate laws with
units of (species units) / (time units). Unit checking can be disabled
by passing the keyword argument `checks=false`.

```
"""
struct ReactionSystem <: ModelingToolkit.AbstractTimeDependentSystem
Expand Down