-
-
Notifications
You must be signed in to change notification settings - Fork 81
Sparse representation of stoichiometric matrices
functions and matrices in complex-based functions
#387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sparse representation of stoichiometric matrices
functions and matrices in complex-based functions
#387
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cad63af
adding SparseArrays dependency
yewalenikhil65 8156551
updating `stoichmat` functions and complex network functions
yewalenikhil65 d384236
updating tests for sparse representation
yewalenikhil65 85d04a2
update project.toml for sparsearrays
yewalenikhil65 0a1566d
add using SparseArrays
yewalenikhil65 7548132
updateand transpose basic stoichmats
isaacsas 636e88f
update complex mat funs
isaacsas 218bf11
update tests
isaacsas f3f7eb8
fix tests
isaacsas 6a2b79e
export reactioncomplexmap
isaacsas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it good idea to be using
SparseMatrixCSC{Int,Int}
entries ? i also remember some conversation thread in Catalyst issues to leave scope for non-integer stoichiometries later probablt in furtureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now it's fine. When we get generalized stoichiometry we'll have to think about what to do here. We don't want it to be type
Any
, so we may need some extra preprocessing to figure out the type, or we just error and don't allow these functions when there is symbolic stoichiometry.