-
-
Notifications
You must be signed in to change notification settings - Fork 11
Bump compat entry for SpecialFunctions to v2 (while keeping the existing v1.3) #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tests fail due to JuliaMath/SpecialFunctions.jl#297 |
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 64.10% 64.10%
=======================================
Files 4 4
Lines 156 156
=======================================
Hits 100 100
Misses 56 56
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Pull Request Test Coverage Report for Build 2455197958
💛 - Coveralls |
|
wait why did the factorial definition need to change though? |
|
Because it was type piracy of Base. Factorial is only for integers, gamma is for floats, and it seems like this parses into floats. |
Pull Request Test Coverage Report for Build 2455197958Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
No description provided.