Skip to content

Conversation

@ven-k
Copy link
Member

@ven-k ven-k commented Jun 7, 2022

No description provided.

@SebastianM-C
Copy link
Member

Tests fail due to JuliaMath/SpecialFunctions.jl#297

@ven-k ven-k changed the title Bump compat entry for SapecialFunctions to v2 (while keeping existin v1.3) Bump compat entry for SpecialFunctions to v2 (while keeping the existing v1.3) Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #42 (0f52bb1) into main (528d62c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   64.10%   64.10%           
=======================================
  Files           4        4           
  Lines         156      156           
=======================================
  Hits          100      100           
  Misses         56       56           
Impacted Files Coverage Δ
src/MathML.jl 100.00% <ø> (ø)
src/maps.jl 32.25% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ChrisRackauckas ChrisRackauckas merged commit ddbf2d6 into SciML:main Jun 7, 2022
@coveralls
Copy link

coveralls commented Jun 7, 2022

Pull Request Test Coverage Report for Build 2455197958

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.103%

Totals Coverage Status
Change from base Build 1534457914: 0.0%
Covered Lines: 100
Relevant Lines: 156

💛 - Coveralls

@anandijain
Copy link
Contributor

wait why did the factorial definition need to change though?

@ChrisRackauckas
Copy link
Member

Because it was type piracy of Base. Factorial is only for integers, gamma is for floats, and it seems like this parses into floats.

@coveralls
Copy link

coveralls commented Sep 29, 2024

Pull Request Test Coverage Report for Build 2455197958

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.103%

Totals Coverage Status
Change from base Build 1534457914: 0.0%
Covered Lines: 100
Relevant Lines: 156

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants