Skip to content

[dotnet] [bidi] Give only one chance to receive from remote end #16360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 5 commits into from
Sep 30, 2025
Merged

[dotnet] [bidi] Give only one chance to receive from remote end #16360

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a50e62d
[dotnet] [bidi] Give only one chance to receive from remote end
nvborisenko Sep 30, 2025
834decb
Update Broker.cs
nvborisenko Sep 30, 2025
8ddd205
Adjust exception message
nvborisenko Sep 30, 2025
ee1a005
But give a chance for commands and responses
nvborisenko Sep 30, 2025
5b27f2a
Update Broker.cs
nvborisenko Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Broker.cs
  • Loading branch information
@nvborisenko
nvborisenko committed Sep 30, 2025
commit 834decbf5b08541c2cbca99c2eb0eec565eb756c
4 changes: 2 additions & 2 deletions dotnet/src/webdriver/BiDi/Communication/Broker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,9 @@ private async Task ReceiveMessagesAsync(CancellationToken cancellationToken)
ProcessReceivedMessage(data);
}
}
catch (Exception ex)
catch (Exception ex) when (ex is not OperationCanceledException)
{
if (cancellationToken.IsCancellationRequested is false && _logger.IsEnabled(LogEventLevel.Error))
if (_logger.IsEnabled(LogEventLevel.Error))
{
_logger.Error($"Couldn't process received BiDi remote message: {ex}");
}
Expand Down
Loading