This repository was archived by the owner on Dec 24, 2022. It is now read-only.
Security fix: Explicitly specified __type should not be even activated when not appropriate #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voloda
commented
Apr 16, 2015
voloda
commented
- I found that when you specify __type in the JSON the deserializer at first activates the instance and then runs the type check
- To me this seems to be a security issue since you can basically activate any object remotely
- The class is immediately thrown away so no further code can be executed just what is inside the constructor
- I succesfully tested remote activation as well
|
+1 |
mythz
added a commit
that referenced
this pull request
Apr 25, 2015
Security fix: Explicitly specified __type should not be even activated when not appropriate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.