read only logic for some mount types #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksayid
requested review from
SethHollandsworth,
hgarvison and
stevendongatmsft
as code owners
hgarvison
reviewed
Sep 19, 2024
hgarvison
approved these changes
Sep 19, 2024
ksayid
force-pushed
the
update-mounts
branch
2 times, most recently
from
1b60f15 to
4b65358
Compare
SethHollandsworth
requested changes
Sep 19, 2024
Owner
SethHollandsworth
left a comment
SethHollandsworth
left a comment
There was a problem hiding this comment.
Couple things to fix, lgtm generally
ksayid
force-pushed
the
update-mounts
branch
from
4b65358 to
1da85aa
Compare
ksayid
added a commit
that referenced
this pull request
Sep 27, 2024
SethHollandsworth
pushed a commit
that referenced
this pull request
Nov 5, 2024
SethHollandsworth
added a commit
that referenced
this pull request
Nov 11, 2024
* read only logic for some mount types (#62) * offloading error checking and updating tests * Gracefully handle broken base64 policies in non-diff mode (#64) * handle broken base64 * address style fixes * adding flag to omit ID from policy * adding ability to not use sidecars via ARM tag * adding workload identity support for vn2 * Add user prompt to confirm policy overwrite for VN2 YAMLs * support for image attached fragments * updating locations where executables are found * updating version to 1.1.0 * updating test value * taking out unused dependency * fixing errors in docs and types * getting rid of whitespace * updating kata tests for linux * updating kata tests for windows * can't have binary files --------- Co-authored-by: Khalil Sayid <[email protected]> Co-authored-by: Khalil Sayid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that certain volume types—ConfigMap, Secret, DownwardAPI, and Projected volumes—are always mounted as read-only, regardless of the user-specified readOnly field in the YAML configuration.