Skip to content

Fix critical bug in 4.1.0 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Fix critical bug in 4.1.0 #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix bug in 4.1.0
  • Loading branch information
@Shane32
Shane32 committed Nov 8, 2021
commit ed386a4ffa6383bad79ec7053676773f15c30e7c
14 changes: 1 addition & 13 deletions src/GraphQL.DI/DIObjectGraphType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,18 +158,6 @@ protected virtual IEnumerable<MethodInfo> GetMethodsToProcess()
return methods;
}

/// <summary>
/// Returns the list of parameters for the specified method.
/// Sorts the list if specified by <see cref="SortMembers"/>.
/// </summary>
protected IEnumerable<ParameterInfo> GetMethodParameters(MethodInfo methodInfo)
{
var parameters = methodInfo.GetParameters().AsEnumerable();
if (SortMembers)
parameters = parameters.OrderBy(x => x.Name, StringComparer.InvariantCultureIgnoreCase);
return parameters;
}

/// <summary>
/// Converts a specified method (<see cref="MethodInfo"/> instance) into a field definition.
/// </summary>
Expand Down Expand Up @@ -200,7 +188,7 @@ protected IEnumerable<ParameterInfo> GetMethodParameters(MethodInfo methodInfo)
{
var resolveFieldContextParameter = Expression.Parameter(typeof(IResolveFieldContext));
var executeParams = new List<Expression>();
foreach (var param in GetMethodParameters(method)) {
foreach (var param in method.GetParameters()) {
var queryArgument = ProcessParameter(method, param, resolveFieldContextParameter, out bool isService, out Expression expr);
anyParamsUseServices |= isService;
if (queryArgument != null)
Expand Down