Skip to content

Fix DISchemaTypes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 17, 2021
Merged

Fix DISchemaTypes #16

merged 5 commits into from
Nov 17, 2021

Conversation

@Shane32
Copy link
Owner

@Shane32 Shane32 commented Nov 17, 2021 •
edited
Loading

  • Cannot set autoMapInputTypes or autoMapOutputTypes parameters in DISchemaTypes constructor due to design of GraphQL.NET. Functionality will be restored once GraphQL.NET design has changed sufficiently.
  • Other bugs in DISchemaTypes fixed, such as ignoring the protected AutoMapInputType and AutoMapOutputType methods altogether.
  • Prevent DIObjectGraphType from detecting property setter "methods" and creating fields for them.
  • Tests added

@Shane32 Shane32 self-assigned this Nov 17, 2021
@github-actions
Copy link

github-actions bot commented Nov 17, 2021

Coverage Report

Totals Coverage
Statements: 95.26% ( 924 / 970 )
Methods: 83.1% ( 118 / 142 )

@Shane32 Shane32 merged commit aa161fc into master Nov 17, 2021
@Shane32 Shane32 deleted the fix_discchematypes branch November 17, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Shane32 Shane32

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Shane32