Skip to content

Fixed on action in tabs for index filters #13144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichaScant wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixed on action in tabs for index filters #13144

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6712f40
first commit
MichaScant Jan 29, 2025
44679a3
test cases added
MichaScant Jan 29, 2025
6317d4e
changed the wording to satisfy pnpm lint
MichaScant Jan 29, 2025
d2ee47c
added changeset
MichaScant Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
added changeset
  • Loading branch information
@MichaScant
MichaScant committed Jan 29, 2025
commit d2ee47c9ade56a1ce1971c6a1b22a3e21ec757df
5 changes: 5 additions & 0 deletions .changeset/unlucky-mugs-juggle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': minor
---

IndexFilters tabs were sometimes not selected if they were placed in the more view menu dropdown, modified this such that onSelect is used instead if the user is attempting to select a tab that is in the more views dropdown menu