Skip to content

[ResourceItem] Fix the property "url" does not prevent redirections while savebar activated #13898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christellealexia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ResourceItem] Fix the property "url" does not prevent redirections while savebar activated #13898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion polaris-react/src/components/ResourceItem/ResourceItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,10 +455,26 @@ class BaseResourceItem extends Component<CombinedProps, State> {
}

if (url && anchor) {
anchor.click();
// PREVENT default navigation
event.preventDefault();
// Check savebar BEFORE navigating
this.handleNavigationWithSaveBarCheck(anchor);
}
};

private async handleNavigationWithSaveBarCheck(anchor: HTMLAnchorElement) {
try {
// Check if shopify saveBar is available and has active unsaved changes
if (typeof window !== 'undefined' && (window as any).shopify?.saveBar) {
await (window as any).shopify.saveBar.leaveConfirmation();
}
// Only navigate if confirmation succeeds
window.location.href = anchor.href;
} catch (error) {
// User cancelled - don't navigate
}
}

// This fires onClick when there is a URL on the item
private handleKeyUp = (event: React.KeyboardEvent<HTMLElement>) => {
const {
Expand Down