Skip to content

Conversation

@Bentlybro
Copy link
Member

Changes

Fixes agents downloaded from marketplace showing creator's graph name instead of marketplace name in user's library.

Problem: When downloading a marketplace agent, the library entry used AgentGraph.name/description (creator's version) instead of the marketplace listing name/description.

Solution: Added optional name and description override fields to LibraryAgent. When adding store agents, these are populated from the marketplace listing. The model layer falls back to graph values if not set (backward compatible).

Modified Files

  • schema.prisma: Added optional name/description to LibraryAgent
  • backend/server/v2/library/db.py: Set marketplace name/description when adding store agents
  • backend/server/v2/library/model.py: Use override fields with fallback to graph values

I still need to fully test this

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Upload a agent to the marketplace with a custom name and description and its stored with that info
    • download that agent and the file name should be the same as the agent name from the marketplace

…in library

Introduces optional 'name' and 'description' fields to the LibraryAgent model, allowing marketplace or custom overrides. Updates database schema, migration, and model logic to prioritize these fields over AgentGraph defaults when present.
@netlify
Copy link

netlify bot commented Nov 10, 2025

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit c9e61c5
🔍 Latest deploy log https://app.netlify.com/projects/auto-gpt-docs-dev/deploys/694441f9b6f23a0008cf248f

@github-actions github-actions bot added the platform/backend AutoGPT Platform - Back end label Nov 10, 2025
@netlify
Copy link

netlify bot commented Nov 10, 2025

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit c9e61c5
🔍 Latest deploy log https://app.netlify.com/projects/auto-gpt-docs/deploys/694441f94b4a0a0007b9de63

@coderabbitai
Copy link

coderabbitai bot commented Nov 10, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bently/open-2299-name-of-downloaded-agent-in-library-is-different-from-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io
Copy link

deepsource-io bot commented Nov 10, 2025

Here's the code health analysis summary for commits 0082a72..c9e61c5. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Renamed the migration file to update its timestamp for better chronological organization of migrations related to library agent custom name and description.
@AutoGPT-Agent
Copy link

Thank you for this PR that fixes agents downloaded from the marketplace showing the creator's graph name instead of the marketplace name in the user's library. The implementation approach looks solid!

A few notes:

  1. Your PR is well-documented, clearly explaining both the problem and solution.

  2. I notice that you mentioned "I still need to fully test this" and your test plan checkboxes aren't all checked. Please complete your testing before this PR can be merged:

    • Upload an agent to the marketplace with a custom name/description and verify it's stored correctly
    • Download that agent and verify the file name matches the agent name from the marketplace
  3. The schema changes look appropriate with good comments explaining the purpose of the new fields.

  4. The implementation logic in both db.py and model.py correctly implements the fallback pattern where the override fields take precedence if available.

Once you've completed your testing plan and checked those boxes, this PR should be ready for merging.

@ntindle
Copy link
Member

ntindle commented Dec 18, 2025

@cursor please try and fix the ci pipleines errors on the backend

@cursor
Copy link

cursor bot commented Dec 18, 2025

Made a quick pass at the backend CI failure and found the culprit: every AutoGPT Platform - Backend CI / test (3.11|3.12|3.13) job dies in the “Run Database Migrations” step with ERROR: schema "platform" does not exist while applying 20251110134206_add_library_agent_custom_name_description (see run https://github.com/Significant-Gravitas/AutoGPT/actions/runs/20346036687/job/58458444382). That migration accidentally targets a platform schema that isn’t present in the ephemeral Supabase shadow database those jobs spin up, so Prisma bails out before the test suite even starts.

I’ve updated the migration to operate on the default schema, which matches the rest of our history:

```2:6:autogpt_platform/backend/migrations/20251110134206_add_library_agent_custom_name_description/migration.sql
ALTER TABLE "LibraryAgent" ADD COLUMN "name" TEXT,
ADD COLUMN "description" TEXT;
COMMENT ON COLUMN "LibraryAgent"."name" IS 'Optional custom name override (e.g., from marketplace). If set, takes precedence over AgentGraph name.';
COMMENT ON COLUMN "LibraryAgent"."description" IS 'Optional custom description override (e.g., from marketplace). If set, takes precedence over AgentGraph description.';

Once this lands, `poetry run prisma migrate dev --name updates` (the step that’s failing in CI) should apply cleanly and the backend pipeline ought to proceed to lint/tests again. I’ll keep an eye on the rerun to confirm nothing else pops up, but please let me know if you still see failures after the workflow re-triggers.

---

<a href="https://cursor.com/background-agent?bcId=bc-af269a24-d8f6-4286-8f32-467d8a7e9b4b"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-af269a24-d8f6-4286-8f32-467d8a7e9b4b"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a>

<sub>[Learn more](https://docs.cursor.com/background-agent/web-and-mobile) about Cursor Agents</sub>

@AutoGPT-Agent
Copy link

Thank you for this PR addressing the marketplace agent naming issue! The implementation looks good conceptually, but there are a few things to address before it's ready to merge:

  1. Your PR checklist shows incomplete testing. Please complete your test plan and check off all items.

  2. Since you've added a new migration, you might want to consider adding migration verification to your test plan to ensure it applies correctly in different environments.

  3. Consider adding a test case for scenarios where an agent has no marketplace name/description to ensure the fallback works as expected.

  4. Double-check if there are any other places in the codebase that might need to be updated to handle these new optional fields (e.g., any API endpoints that return library agent data).

Once you've completed your testing and addressed these points, please update the PR.

@cursor
Copy link

cursor bot commented Dec 18, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@AutoGPT-Agent
Copy link

Thank you for this PR to fix the marketplace agent name/description issue in the library.

The implementation looks good, adding optional name/description fields to LibraryAgent and properly handling the override logic. The code changes match the stated intention in the PR description.

Before this can be approved, please complete the remaining test item in your test plan:

  • Upload an agent to the marketplace with a custom name and description and verify it's stored with that info
  • Download that agent and verify the file name matches the agent name from the marketplace

Once you've completed these tests and checked the remaining item, this PR should be ready to merge. The changes are focused and address the specific issue mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform/backend AutoGPT Platform - Back end size/m

Projects

Status: 🆕 Needs initial review

Development

Successfully merging this pull request may close these issues.

5 participants