Skip to content

feat: add support for webpack@5 and html-webpack-plugin@5 #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 20, 2021
+71 −12
Merged

feat: add support for webpack@5 and html-webpack-plugin@5 #187

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2d841ad
Updates for Webpack 5
alexgorbatchev Feb 19, 2021
13335c8
Merge branch 'main' into webpack5fix
SimenB Feb 20, 2021
4a31a1a
Merge branch 'main' into webpack5fix
SimenB Feb 20, 2021
40a4d99
Merge branch 'main' into webpack5fix
SimenB Feb 20, 2021
ea367ce
chore: fix lint
SimenB Feb 20, 2021
18e52be
Merge branch 'main' into webpack5fix
SimenB Feb 20, 2021
16fc528
chore: test on webpack-plugin v5
SimenB Feb 20, 2021
fc201da
remove coverage threshold
SimenB Feb 20, 2021
daa88ca
fix node 6 support
SimenB Feb 20, 2021
c49b85b
Revert "remove coverage threshold"
SimenB Feb 20, 2021
377d833
skip html webpack plugin v5 on webpack v4
SimenB Feb 20, 2021
3ae6d3f
attempt a single matrix
SimenB Feb 20, 2021
5fa60b3
checkout a file
SimenB Feb 20, 2021
a50602c
one more exclusion
SimenB Feb 20, 2021
e53408f
Merge branch 'main' into webpack5fix
SimenB Feb 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix lint
  • Loading branch information
@SimenB
SimenB committed Feb 20, 2021
commit ea367cea8b4f4e80a8f4aad24d8c0301e1a30198
13 changes: 6 additions & 7 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,9 @@ export default class AddAssetHtmlPlugin {
}
}

const addedFilename = await (htmlPluginData.plugin.addFileToAssets ||
addFileToAssetsWebpack5)(filepath, compilation);
const addedFilename = await (
htmlPluginData.plugin.addFileToAssets || addFileToAssetsWebpack5
)(filepath, compilation);

let suffix = '';
if (hash) {
Expand All @@ -161,11 +162,9 @@ export default class AddAssetHtmlPlugin {
const relatedFiles = await globby(`${filepath}.*`);
await Promise.all(
relatedFiles.sort().map(async relatedFile => {
const addedMapFilename = await (htmlPluginData.plugin
.addFileToAssets || addFileToAssetsWebpack5)(
relatedFile,
compilation,
);
const addedMapFilename = await (
htmlPluginData.plugin.addFileToAssets || addFileToAssetsWebpack5
)(relatedFile, compilation);
resolveOutput(compilation, addedMapFilename, outputPath);
}),
);
Expand Down