Skip to content

Add support for expressive code in snippets #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 4 commits into from
May 3, 2025
Merged

Add support for expressive code in snippets #717

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fddba75
Add support for expressive code blocks in snippets
khalidabuhakmeh Apr 28, 2025
c9ab3d6
Add ExpressiveCode class and integrate Pattern handling
khalidabuhakmeh May 2, 2025
7aee95e
Refactor Regex initialization with conditional compilation.
khalidabuhakmeh May 2, 2025
274ef54
Refactor snippet language declaration handling.
khalidabuhakmeh May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor Regex initialization with conditional compilation. 
Reorganized Regex initialization using `#if NET8_0_OR_GREATER` to leverage `GeneratedRegex` for .NET 8+ and fallback to static initialization otherwise instance is null.
  • Loading branch information
@khalidabuhakmeh
khalidabuhakmeh committed May 2, 2025
commit 7aee95ecfdffbe1d3bf3da3ca4fe53eae00ee857
12 changes: 6 additions & 6 deletions src/MarkdownSnippets/Reading/ExpressiveCode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
internal partial class ExpressiveCode
{
#if NET8_0_OR_GREATER
[GeneratedRegex(@"([a-zA-Z0-9\-_]+)(?:\((.*?)\))?")]
protected partial Regex KeyPatternRegex();
#else
protected static readonly Regex KeyPatternRegex = new(@"([a-zA-Z0-9\-_]+)(?:\((.*?)\))?");
#endif
public ExpressiveCode() =>
#if NET8_0_OR_GREATER
Pattern = KeyPatternRegex();
Expand All @@ -8,10 +14,4 @@ public ExpressiveCode() =>
#endif
public static ExpressiveCode Instance { get; } = new();
public Regex Pattern { get; }
#if NET8_0_OR_GREATER
[GeneratedRegex(@"([a-zA-Z0-9\-_]+)(?:\((.*?)\))?")]
protected partial Regex KeyPatternRegex();
#else
protected static readonly Regex KeyPatternRegex = new(@"([a-zA-Z0-9\-_]+)(?:\((.*?)\))?");
#endif
}