Merged
Conversation
Almond-Peach
requested review from
Hayk985,
ManukyanQristine and
artur-ghonyan
# Conflicts: # app/src/main/java/com/simply/birthdayapp/di/DataModule.kt # app/src/main/res/values/strings.xml
|
|
||
| LaunchedEffect(showNetworkDialog) { | ||
| if (keepShowingNetworkDialog && showNetworkDialog.not()) { | ||
| lifecycleScope.launch { |
There was a problem hiding this comment.
Why do you need to open 'scope' here?
| lifecycleOwner = this, | ||
| ) | ||
| var keepShowingNetworkDialog by rememberSaveable { mutableStateOf(true) } | ||
| var showNetworkDialog by rememberSaveable { mutableStateOf(true) } |
There was a problem hiding this comment.
Why are the default values set to 'true'?
Contributor
Author
There was a problem hiding this comment.
By default, a dialog appears when the user is disconnected.
The dialog can be dismissed and shown again after 10 seconds.
The dialog will not be shown again until the app is restarted if the user clicks Don't show.
That is why these default values are set to true.
P.S. Have renamed that variables to align them with the user actions Do not show, Dismiss.
| onDismiss: () -> Unit = {}, | ||
| ) { | ||
| AlertDialog(onDismissRequest = onDismiss) { | ||
| Surface( |
artur-ghonyan
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.