Skip to content

Conversation

@Ali-Faraz-simpplr
Copy link
Contributor

@Ali-Faraz-simpplr Ali-Faraz-simpplr commented Aug 16, 2023

Jira:

DE-9431

Description:

  • Middleware added for making logger compatible for fastapi
  • Context vars being used instead of using local from threading

Type of change:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist (put x in bracket to check):

Please do not delete options here.

  • I have performed a self-review of my code
  • Existing unit tests pass locally with my changes
  • I have written coverage for new code
  • I have updated the Production deployment sheet if this service required production changes in this sprint

Copy link
Collaborator

@kashyap-thacker kashyap-thacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check the minor comment and merge.

@Ali-Faraz-simpplr Ali-Faraz-simpplr merged commit bde4f89 into main Aug 16, 2023
@Ali-Faraz-simpplr Ali-Faraz-simpplr deleted the DE-9431-improvements-for-fastapi-compatibility branch August 16, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants