Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(desktop): create agent presets with custom icons and suggested IDs
  • Loading branch information
SivanCola committed Nov 2, 2026
commit e50e513774779e72bda1e0bb508ad0293bd0845c
39 changes: 39 additions & 0 deletions desktop/agent_preset_icon_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
package main

import (
"bytes"
"encoding/base64"
"image"
"image/png"
"testing"

"deepzora/internal/agentpreset"
)

func TestAgentPresetCustomIconAuthoring(t *testing.T) {
a := newManualSessionTestApp(t)
var data bytes.Buffer
if err := png.Encode(&data, image.NewNRGBA(image.Rect(0, 0, 128, 128))); err != nil {
t.Fatal(err)
}
preset := agentpreset.Default()
preset.IconImage = "data:image/png;base64," + base64.StdEncoding.EncodeToString(data.Bytes())
saved, err := a.SaveAgentPreset("", "user", "avatar", agentpreset.Render(preset))
if err != nil || saved.IconImage != preset.IconImage {
t.Fatalf("save did not return the custom image: %v", err)
}
list, err := a.ListAgentPresets("")
if err != nil || len(list.Presets) != 2 || list.Presets[1].IconImage != preset.IconImage {
t.Fatalf("list did not return the persisted custom image: %v", err)
}
if _, err := a.SaveAgentPreset("", "user", "avatar-copy", agentpreset.Render(saved)); err != nil {
t.Fatal(err)
}
if err := a.DeleteAgentPreset("", "user", "avatar"); err != nil {
t.Fatal(err)
}
list, err = a.ListAgentPresets("")
if err != nil || len(list.Presets) != 2 || list.Presets[1].IconImage != preset.IconImage {
t.Fatalf("copy lost its image when the original was deleted: %v", err)
}
}
130 changes: 130 additions & 0 deletions desktop/frontend/bench/agent-presets.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
import assert from "node:assert/strict";
import { mkdir } from "node:fs/promises";
import path from "node:path";
import { fileURLToPath } from "node:url";
import { createServer } from "vite";
import { newSessionButton } from "./app-page-actions.mjs";

const root = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
process.env.PLAYWRIGHT_BROWSERS_PATH ??= path.join(root, ".pw-browsers");
const { chromium } = await import("playwright");
const server = await createServer({ root, logLevel: "error", server: { host: "127.0.0.1", port: 0, hmr: false } });
await server.listen();
let browser;
try {
browser = await chromium.launch({ headless: true, executablePath: process.env.CHROME_EXECUTABLE });
const page = await browser.newPage({ viewport: { width: 1440, height: 1000 }, locale: "en-US" });
const errors = [];
page.on("pageerror", error => errors.push(error.message));
await page.goto(`http://127.0.0.1:${server.httpServer.address().port}/?mock=demo&bench=1`);
await page.locator("#composer-input").waitFor();
await newSessionButton(page).click();
const picker = page.getByRole("button", { name: "Agent preset: Default", exact: true });
await picker.focus();
await picker.press("ArrowDown");
await page.getByRole("menu", { name: "Agent preset: Default", exact: true }).waitFor();
await page.waitForFunction(() => document.activeElement?.getAttribute("role") === "menuitemradio");
await page.keyboard.press("End");
assert.equal(await page.evaluate(() => document.activeElement.textContent), "New agent preset…");
await page.keyboard.press("Enter");
const editor = page.locator(".agent-preset-editor");
await editor.waitFor();
assert.equal(await editor.getAttribute("aria-label"), "New preset");
await page.waitForFunction(() => document.activeElement?.id.endsWith("-name"));
console.log("PASS picker action opens the creation form and focuses its name");
await editor.getByLabel("Name", { exact: true }).fill("Custom avatar");
assert.equal(await editor.getByLabel("ID", { exact: true }).inputValue(), "custom-avatar");
await editor.getByLabel("ID", { exact: true }).fill("avatar-manual");
await editor.getByLabel("Name", { exact: true }).fill("Custom avatar renamed");
assert.equal(await editor.getByLabel("ID", { exact: true }).inputValue(), "avatar-manual", "manual ID survives name changes");
await editor.getByLabel("Name", { exact: true }).fill("Custom avatar");

const png = await page.evaluate(() => {
const canvas = document.createElement("canvas"); canvas.width = 400; canvas.height = 200;
const context = canvas.getContext("2d"); context.fillStyle = "red"; context.fillRect(0, 0, 200, 200);
context.fillStyle = "blue"; context.fillRect(200, 0, 200, 200);
return canvas.toDataURL("image/png").split(",")[1];
});
const upload = page.locator('.agent-preset-icon-picker input[type="file"]');
const file = { name: "avatar.png", mimeType: "image/png", buffer: Buffer.from(png, "base64") };
await upload.setInputFiles(file);
await page.getByRole("group", { name: "Crop icon", exact: true }).waitFor();
assert.equal(await editor.getByRole("button", { name: "Save", exact: true }).isDisabled(), true, "save waits for a crop decision");
await editor.getByLabel("Zoom", { exact: true }).fill("2");
await editor.getByLabel("Horizontal position").fill("0");
await page.waitForFunction(() => document.querySelector('.agent-preset-icon-crop canvas')?.getContext("2d").getImageData(96, 96, 1, 1).data[0] === 255);
await page.getByRole("button", { name: "Use icon", exact: true }).click();
console.log("PASS square crop applied");
await page.waitForFunction(() => document.querySelector('.agent-preset-editor [aria-label="Custom icon"] img')?.naturalWidth === 128);
await editor.getByRole("button", { name: "Save", exact: true }).click();
const row = page.getByRole("article", { name: "Custom avatar", exact: true });
await row.waitFor();
console.log("PASS image saved and listed");
const stored = await row.locator("img").getAttribute("src");
assert.match(stored, /^data:image\/png;base64,/u);
assert.ok(stored.length < 128 * 1024);
await row.getByRole("button", { name: "Copy", exact: true }).click();
assert.equal(await page.locator('[aria-label="Custom icon"] img').getAttribute("src"), stored, "copy retains embedded image");
await page.getByRole("button", { name: "Cancel", exact: true }).click();
await page.locator("#management-back").click();
await picker.click();
const option = page.getByRole("menuitemradio", { name: /Custom avatar/u });
assert.equal(await option.locator("img").getAttribute("src"), stored, "picker and list use the same persisted image");
await option.click();
await page.getByRole("button", { name: "Agent preset: Custom avatar", exact: true }).waitFor();
console.log("PASS saved image renders in the composer picker");
assert.equal(await page.locator(".agent-preset-choice .composer-choice img").getAttribute("src"), stored);
await page.getByRole("button", { name: "Agent preset: Custom avatar", exact: true }).click();
await page.getByRole("menuitem", { name: "New agent preset…", exact: true }).click();
await editor.waitFor();
await editor.getByRole("button", { name: "Cancel", exact: true }).click();
assert.equal(await editor.count(), 0, "consumed create request does not reopen after cancel");
await row.getByRole("button", { name: "Edit", exact: true }).click();

for (const [badFile, message] of [
[{ name: "vector.svg", mimeType: "image/svg+xml", buffer: Buffer.from("<svg/>") }, "Choose a PNG, JPEG or WebP image."],
[{ name: "huge.png", mimeType: "image/png", buffer: Buffer.alloc(5 * 1024 * 1024 + 1) }, "Choose an image smaller than 5 MB."],
[{ name: "broken.png", mimeType: "image/png", buffer: Buffer.from("broken") }, "Could not read this image. Try another file."],
]) {
await upload.setInputFiles(badFile);
await page.getByRole("alert").filter({ hasText: message }).waitFor();
assert.equal(await page.locator('[aria-label="Custom icon"] img').getAttribute("src"), stored, "invalid upload retains the saved image");
}
await upload.setInputFiles(file);
await page.getByRole("button", { name: "Use icon", exact: true }).waitFor();
await page.locator(".agent-preset-icon-crop").getByRole("button", { name: "Cancel", exact: true }).click();
assert.equal(await page.locator('[aria-label="Custom icon"] img').getAttribute("src"), stored, "cancelling crop keeps previous image");
await upload.setInputFiles(file);
await editor.getByLabel("Zoom", { exact: true }).fill("2");
await editor.getByLabel("Horizontal position").fill("100");
await page.getByRole("button", { name: "Use icon", exact: true }).click();
assert.notEqual(await page.locator('[aria-label="Custom icon"] img').getAttribute("src"), stored, "replacement applies the new crop");
const evidence = process.env.DEEPZORA_PRESET_EVIDENCE;
if (evidence) {
await mkdir(evidence, { recursive: true });
await page.screenshot({ path: path.join(evidence, "custom-icon-editor.png"), fullPage: true });
}
await page.getByRole("button", { name: "Restore default icon", exact: true }).click();
assert.equal(await page.locator('[aria-label="Custom icon"]').count(), 0);
assert.equal(await page.getByRole("radio", { name: "bot", exact: true }).getAttribute("aria-checked"), "true");

// A late decode must not undo a subsequent built-in icon choice.
await page.evaluate(() => {
const decode = window.createImageBitmap.bind(window);
window.createImageBitmap = file => new Promise(resolve => { window.releasePresetImage = async () => resolve(await decode(file)); });
});
await upload.setInputFiles(file);
await page.getByText("Reading image…", { exact: true }).waitFor();
await page.getByRole("radio", { name: "search", exact: true }).click();
await page.evaluate(() => window.releasePresetImage());
assert.equal(await page.locator(".agent-preset-icon-crop").count(), 0, "late decode cannot reopen crop");
assert.equal(await page.getByRole("radio", { name: "search", exact: true }).getAttribute("aria-checked"), "true");
await page.getByRole("form").getByRole("button", { name: "Save", exact: true }).click();
await row.waitFor();
assert.equal(await row.locator("img").count(), 0, "reset and built-in choice persist");
assert.deepEqual(errors, []);
console.log("PASS preset picker creation, keyboard navigation, image crop/save/copy/readback, upload validation, cancel/reset and stale decode");
} finally {
await browser?.close();
await server.close();
}
1 change: 1 addition & 0 deletions desktop/frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"test:composer": "node scripts/run-ci-tests.mjs --group composer",
"test:composer-browser": "node bench/composer-transcript-stability.mjs",
"test:popover-browser": "node bench/anchored-popover-lifecycle.mjs",
"test:agent-presets-browser": "node bench/agent-presets.mjs",
"test:popover-electron": "node bench/anchored-popover-lifecycle.mjs --electron",
"test": "node scripts/run-ci-tests.mjs",
"test:performance": "node scripts/run-ci-tests.mjs --group performance",
Expand Down
28 changes: 28 additions & 0 deletions desktop/frontend/src/__tests__/agent-presets-ui.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,14 @@ await click(button("New preset"));
assert.equal(checkbox("Complete system prompt").checked, false, "new presets use an assembled system prompt");
assert.equal(checkbox("Include runtime context").checked, true, "new presets include runtime context");
await fill("Name", "Persona");
assert.equal(rootEl.querySelector<HTMLInputElement>('input[id$="-id"]')!.value, "persona", "name generates a valid ID");
await fill("Name", "Review");
assert.equal(rootEl.querySelector<HTMLInputElement>('input[id$="-id"]')!.value, "review-2", "automatic ID avoids scope collisions");
await fill("ID", "default");
assert.equal(button("Save").disabled, true, "reserved ID is rejected");
await fill("ID", "persona");
await fill("Name", "Renamed Persona");
assert.equal(rootEl.querySelector<HTMLInputElement>('input[id$="-id"]')!.value, "persona", "manual ID survives later name edits");
await click(checkbox("Complete system prompt"));
assert.equal(button("Save").disabled, true, "complete mode needs a body even when Keep is selected");
assert.equal(rootEl.querySelector<HTMLTextAreaElement>('textarea[id$="-body"]')!.required, true);
Expand Down Expand Up @@ -206,6 +211,20 @@ await act(async () => { releaseChoice!(); await flush(); });
await settle();
assert.equal(pending.at(-1), false);
assert.ok(rootEl.querySelector('button[aria-label="Agent preset: Review"]'), "readback displays the saved preset");
const { useAppNavigationStore } = await import("../store/appNavigation");
await click(rootEl.querySelector('button[aria-label="Agent preset: Review"]')!);
const createAction = document.querySelector<HTMLButtonElement>('[role="menuitem"]')!;
assert.equal(createAction.textContent, "New agent preset…");
await click(createAction);
assert.deepEqual(useAppNavigationStore.getState().page, { kind: "settings", tab: "agent-presets" });
assert.equal(useAppNavigationStore.getState().settingsFocus?.target, "agent-preset-create");
assert.equal(selections.length, 1, "new preset action does not switch the active preset");
await act(async () => root.render(<LocaleProvider><AgentPresetsSettingsPage tabId="tab-a" workspaceKey="a" /></LocaleProvider>));
await settle();
assert.ok(rootEl.querySelector('form[aria-label="New preset"]'), "picker action opens the creation form directly");
assert.equal(useAppNavigationStore.getState().settingsFocus, null, "creation request is consumed");
await click(button("Cancel"));
assert.equal(rootEl.querySelector(".agent-preset-editor"), null, "cancel returns to the list without reopening creation");
view = { ...view, current: "review", presets: [builtin, review], locked: true, problems: [] };
await act(async () => { root.render(<LocaleProvider><AgentPresetChoice tabId="tab-a" running={false} locked onPendingChange={value => pending.push(value)} /></LocaleProvider>); await flush(); });
await settle();
Expand Down Expand Up @@ -247,6 +266,15 @@ await act(async () => { resolveA!({ ...view, current: "old-tab" }); await flush(
assert.equal(fetched?.view, null, "late response from the previous tab is ignored");
await act(async () => { resolveB!({ ...view, current: "new-tab" }); await flush(); });
assert.equal(fetched?.view?.current, "new-tab");
const { AgentPresetIcon } = await import("../components/AgentPresetIcon");
const badImage = "data:image/png;base64,aW52YWxpZA==";
await act(async () => root.render(<AgentPresetIcon icon="search" image={badImage} />));
assert.ok(rootEl.querySelector("img"), "embedded image is used before the glyph");
await act(async () => rootEl.querySelector("img")!.dispatchEvent(new window.Event("error")));
assert.ok(rootEl.querySelector("svg.lucide-search"), "failed image falls back to the preset glyph");
assert.equal(rootEl.querySelector("img"), null);
await act(async () => root.render(<AgentPresetIcon image="https://example.com/icon.png" />));
assert.ok(rootEl.querySelector("svg.lucide-bot"), "untrusted image locations use the default without a network fetch");
await act(async () => root.unmount());
stub.uninstall();
dom.window.close();
Expand Down
27 changes: 26 additions & 1 deletion desktop/frontend/src/__tests__/agent-presets.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import assert from "node:assert/strict";
import { agentPresetTools, nextAgentPresetCopyID, renderAgentPreset, type AgentPreset } from "../lib/agentPresets";
import { AGENT_PRESET_ID_PATTERN, agentPresetTools, nextAgentPresetCopyID, suggestedAgentPresetID, renderAgentPreset, type AgentPreset } from "../lib/agentPresets";
import { makeMockAgentPresetBindings } from "../lib/agentPresetMock";
import type { TabMeta } from "../lib/types";
import { isPresetIconImage, presetIconCrop } from "../lib/agentPresetImage";

const special = { name: 'Reviewer: "safe"\n---', description: "true # comment\n&alias", body: "# Review\n\n---\nCheck everything.", keepCoding: false, complete: true, includeRuntimeContext: false, tools: ["read_*", "mcp:research"] };
const content = renderAgentPreset(special);
Expand All @@ -15,11 +16,35 @@ assert.doesNotMatch(renderAgentPreset({ ...special, tools: null }), /^tools:/mu,
assert.match(renderAgentPreset({ ...special, tools: [] }), /^tools: \[\]$/mu, "an explicit empty surface remains empty");
assert.deepEqual(agentPresetTools("read_file, grep\nread_file\r\nmcp:research, \n"), ["read_file", "grep", "mcp:research"]);
assert.equal(nextAgentPresetCopyID("review", [{ id: "review-copy" }, { id: "review-copy-2" }] as AgentPreset[]), "review-copy-3");
assert.equal(suggestedAgentPresetID("Code Reviewer", "user", []), "code-reviewer");
assert.equal(suggestedAgentPresetID("Café & Docs", "user", []), "cafe-docs");
assert.equal(suggestedAgentPresetID("default", "user", []), "default-2");
assert.equal(suggestedAgentPresetID("Review", "user", [{ id: "review", scope: "user" }, { id: "review-2", scope: "user" }] as AgentPreset[]), "review-3");
assert.equal(suggestedAgentPresetID("Review", "project", [{ id: "review", scope: "user" }] as AgentPreset[]), "review", "project override remains possible");
assert.equal(suggestedAgentPresetID(" ", "user", []), "");
for (const name of ["代码审查员", "🎨", "a".repeat(100)]) {
const generated = suggestedAgentPresetID(name, "user", []);
assert.match(generated, AGENT_PRESET_ID_PATTERN);
assert.equal(suggestedAgentPresetID(name, "user", []), generated, "non-Latin fallback is deterministic");
assert.match(suggestedAgentPresetID(name, "user", [{ id: generated, scope: "user" }] as AgentPreset[]), AGENT_PRESET_ID_PATTERN);
}

let tabs = [{ id: "a", active: true, workspaceRoot: "/project-a", topicId: "blank", agentPreset: "default" },
{ id: "b", workspaceRoot: "/project-b", topicId: "blank" }] as TabMeta[];
const changed: string[] = [];
const mock = makeMockAgentPresetBindings({ tabs: () => tabs, update: tab => { tabs = tabs.map(item => item.id === tab.id ? tab : item); }, isBlank: id => id === "blank", changed: async id => { changed.push(id); } });
const image = "data:image/png;base64,iVBORw0KGgo=";
const withImage = await mock.SaveAgentPreset("a", "user", "avatar", renderAgentPreset({ ...special, icon: "search", iconImage: image }));
assert.equal(withImage.iconImage, image);
assert.equal(withImage.icon, "search", "mock and backend preserve glyph fallback alongside custom images");
const imageCopy = await mock.SaveAgentPreset("a", "user", "avatar-copy", renderAgentPreset(withImage));
await mock.DeleteAgentPreset("a", "user", "avatar");
assert.equal(imageCopy.iconImage, image, "copies embed their own image");
assert.equal(isPresetIconImage("https://example.com/avatar.png"), false);
assert.equal(isPresetIconImage("data:image/svg+xml;base64,PHN2Zy8+"), false);
assert.equal(isPresetIconImage("data:image/png;base64," + "A".repeat(128 * 1024)), false);
assert.deepEqual(presetIconCrop(400, 200, 1, 50, 50), { side: 200, left: 100, top: 0 });
assert.deepEqual(presetIconCrop(400, 200, 2, 100, 100), { side: 100, left: 300, top: 100 });
const saved = await mock.SaveAgentPreset("a", "user", "review", content);
assert.deepEqual({ name: saved.name, description: saved.description, body: saved.body, keepCoding: saved.keepCoding, complete: saved.complete, includeRuntimeContext: saved.includeRuntimeContext, tools: saved.tools }, special, "canonical YAML preserves prompt options, special scalars and persona body");
const legacy = await mock.SaveAgentPreset("a", "user", "legacy", '---\nname: "Legacy"\n---\n');
Expand Down
Loading
Loading