Skip to content

fix(desktop): preserve DeepSeek endpoints and show model IDs - #150

Merged
SivanCola merged 2 commits into
mainfrom
codex/fix-deepseek-endpoint-model-identity
Nov 3, 2026
Merged

SivanCola merged 2 commits into
mainfrom
codex/fix-deepseek-endpoint-model-identity

Conversation

@SivanCola

@SivanCola SivanCola commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Fix a 404 when the complete DeepSeek /anthropic/messages URL is entered as the API address: recognize both Messages URL forms, preserve complete request targets at runtime, and derive model-discovery paths from the API base instead of appending to /messages.
  • Show model names together with routing IDs in connection settings and the chat model picker. The selected-model button uses the display name, while its tooltip includes the ID and connection. Models without a distinct name keep the existing compact display.
  • Keep discovery, saving, selection, and favorites keyed by the original model IDs and connection references. Update browser development fixtures to exercise distinct names and IDs.

Verification

  • Root owning packages: go test ./internal/config ./internal/provider/anthropic ./internal/provider/openai.
  • Desktop HTTP regression exercises discovery → save/reload → Messages probe and verifies deepseek-flash and /anthropic/messages on the wire; related provider/endpoint tests pass.
  • Frontend build, test typecheck, endpoint, DeepSeek refresh/save, model-switcher, responsive settings, and composer-menu viewport tests pass.
  • Chromium: 228 settings page/editor cases, 180 theme/layout/width/zoom cases, and the app browser lifecycle gate pass. Also visually checked the actual frontend in the in-app browser, including a 400px model-settings layout.
  • Full frontend suite: pnpm test passes all 508/508 commands, including test typechecking.
  • make lint and Desktop golangci-lint run --timeout=5m ./... pass.
  • Desktop discovery/save/Messages HTTP regression also passes with go test -race.
  • Hosted checks on 2959adad1: root and Desktop tests on Linux/macOS/Windows, lint, race tests (including macOS lifecycle), frontend/Electron tests, Chromium checks, Desktop aggregate, and all CodeQL analyses pass. CI timing-evidence archival also passes; the complete CI and CodeQL workflows are green.

Documentation and compatibility

  • No persisted model-ID, favorite, or connection-reference migration. Explicit custom request URL overrides remain authoritative.
  • Supports the documented DeepSeek Messages paths: /anthropic/v1/messages and /anthropic/messages (API reference).
  • Browser previews use development fixture data; no live DeepSeek account acceptance is claimed.

Related issues

User-reported DeepSeek 404 and model-name/ID confusion; no linked GitHub issue.

@SivanCola
SivanCola merged commit dfcd04d into main Nov 3, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant