Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(team): add isolated memory review and Desktop schedules
  • Loading branch information
SivanCola committed Nov 3, 2026
commit 04120fe5e76acd8212b8570c9c6df8b8613de1e2
17 changes: 16 additions & 1 deletion desktop/frontend/bench/team-desktop.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,21 @@ try {
for(const name of ["Chief","Ada With Spaces"])await settings.getByRole("checkbox",{name,exact:true}).check();
await settings.locator("button[type=submit]").click();
await settings.getByRole("heading",{name:"Project group",exact:true}).waitFor();
const memory=settings.locator('.settings-section').filter({has:page.getByRole('heading',{name:'Team memory',exact:true})});
assert.equal(await settings.getByRole('checkbox',{name:'Automatic memory review',exact:true}).isChecked(),false,'review is opt-in');
await memory.getByRole('button',{name:'Add memory',exact:true}).click();
await memory.getByRole('textbox',{name:'Summary',exact:true}).fill('Working language');
await memory.getByRole('textbox',{name:'Content',exact:true}).fill('Use Chinese for explanations');
await memory.getByRole('button',{name:'Save',exact:true}).click();
await memory.getByRole('heading',{name:'Working language',exact:true}).waitFor();
const schedules=settings.locator('.settings-section').filter({has:page.getByRole('heading',{name:'Team schedules',exact:true})});
await schedules.getByRole('button',{name:'New schedule',exact:true}).click();
await schedules.getByRole('textbox',{name:'Name',exact:true}).fill('Release review');
await schedules.getByRole('textbox',{name:'Task',exact:true}).fill('Review the release checklist');
await schedules.getByRole('button',{name:'Save',exact:true}).click();
await schedules.getByRole('heading',{name:'Release review',exact:true}).waitFor();
await schedules.getByRole('button',{name:'Run now',exact:true}).click();
await schedules.getByText('Scheduled input accepted. Check the target conversation for execution and approvals.',{exact:true}).waitFor();
await page.getByRole("button",{name:"Back to workspace",exact:true}).click();
const sidebar=page.locator(".team-sidebar");
await sidebar.getByRole("button",{name:/Project group/}).click();
Expand All @@ -59,7 +74,7 @@ try {
await page.screenshot({path:path.join(output,`team-group-${width}.png`)});
}
assert.deepEqual(errors,[],"no browser runtime errors");
console.log("PASS Team creation, ordering, structured mentions, canonical switching, retained drafts, at-most-once display and responsive group chat");
console.log("PASS Team creation, ordering, memory edits, review opt-in, schedule acceptance, structured mentions, canonical switching, retained drafts, at-most-once display and responsive group chat");
} finally {
await page.close();await browser.close();if(preview)await preview.httpServer.close();
}
72 changes: 72 additions & 0 deletions desktop/frontend/src/components/TeamMemorySettings.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import { useEffect, useState } from "react";
import type { MemoryFact, TeamMemoryTarget, TeamMemoryView, TeamView, TeamMemoryReviewStatus } from "../generated/desktopContract.generated";
import { app } from "../lib/bridge";
import { useT } from "../lib/i18n";
import { notifyTeamChanged } from "../lib/useTeam";
import { useTeamOperation } from "../lib/useTeamOperation";
import { SettingsFeedback, useSettingsDraft, useSettingsExperience } from "./SettingsExperience";
import { SettingsField, SettingsSection } from "./SettingsForm";
import { SettingsSelect } from "./SettingsSelect";
import { InlineConfirmButton } from "./InlineConfirmButton";

export function TeamMemorySettings({team,reload}:{team:TeamView;reload:()=>Promise<unknown>}){
const t=useT(),{requestLeave}=useSettingsExperience();
const [scope,setScope]=useState("team"),[version,setVersion]=useState(0);
const [view,setView]=useState<TeamMemoryView|null>(null),[error,setError]=useState("");
const [editing,setEditing]=useState<MemoryFact|null>(null);
const targets=[{value:"team",label:t("team.memoryTeam"),target:{tier:"team"}},...team.roster.agents.map(a=>({value:`agent:${a.id}`,label:`${t("team.memoryPrivate")} · ${a.name}`,target:{tier:"private",agentId:a.id}})),...team.roster.groups.map(g=>({value:`group:${g.id}`,label:`${t("team.groups")} · ${g.name}`,target:{tier:"group",groupId:g.id}}))];
const target:TeamMemoryTarget|undefined=targets.find(x=>x.value===scope)?.target;
const targetKey=JSON.stringify(target??null);
useEffect(()=>{let active=true;setView(null);setError("");const selected=JSON.parse(targetKey) as TeamMemoryTarget|null;if(selected)void app.GetTeamMemory(selected).then(value=>{if(active)setView(value);},cause=>{if(active)setError(String(cause));});return()=>{active=false;};},[targetKey,version]);
const blank:MemoryFact={name:"",description:"",body:"",type:"user",scope:"project",freshness:""};
const changed=()=>{setEditing(null);setVersion(v=>v+1);notifyTeamChanged();};
return <>
<TeamReviewPreferences team={team} reload={reload}/>
<SettingsSection title={t("team.memory")} description={t("team.memoryHint")}>
<SettingsField label={t("team.memoryScope")}><SettingsSelect value={scope} options={targets} onValueChange={value=>requestLeave(()=>{setEditing(null);setScope(value);})}/></SettingsField>
{error&&<SettingsFeedback kind="error">{error}</SettingsFeedback>}
{!target&&<SettingsFeedback kind="error">{t("team.memoryTargetGone")}</SettingsFeedback>}
{view&&target&&(editing?<TeamMemoryEditor key={`${scope}:${editing.id??"new"}`} target={target} view={view} initial={editing} writable={team.writable} onSaved={changed} onCancel={()=>setEditing(null)} onReload={()=>requestLeave(()=>{setEditing(null);setVersion(v=>v+1);})}/>:<>
<button type="button" className="btn btn--small" disabled={!team.writable} onClick={()=>setEditing(blank)}>{t("team.memoryAdd")}</button>
{view.facts.length===0&&<SettingsFeedback kind="empty">{t("common.none")}</SettingsFeedback>}
{view.facts.map(fact=><article className="cap-skill-card" key={fact.id}><h3>{fact.description||fact.name}</h3><p className="cap-skill-card__desc">{fact.body}</p><button type="button" className="btn btn--small" disabled={!team.writable} onClick={()=>setEditing(fact)}>{t("common.edit")}</button></article>)}
</>)}
</SettingsSection>
</>;
}

function TeamMemoryEditor({target,view,initial,writable,onSaved,onCancel,onReload}:{target:TeamMemoryTarget;view:TeamMemoryView;initial:MemoryFact;writable:boolean;onSaved:()=>void;onCancel:()=>void;onReload:()=>void}){
const t=useT(),operation=useTeamOperation();
const [draft,setDraft]=useState(initial);
const valid=Boolean(draft.description.trim()&&draft.body.trim());
const commit=(archive:boolean)=>operation.run({target,draft,archive,revision:view.rosterRevision},requestId=>app.SaveTeamMemory({target,expectedRosterRevision:view.rosterRevision,requestId,fact:draft,archive}),onSaved);
const guard=useSettingsDraft({label:t("team.memory"),order:3,dirty:JSON.stringify(draft)!==JSON.stringify(initial),busy:operation.busy,canSave:writable&&valid,save:()=>commit(false),discard:()=>setDraft(initial)});
return <form onSubmit={event=>{event.preventDefault();if(valid)void commit(false);}} aria-busy={operation.busy}>
{operation.error&&<SettingsFeedback kind="error">{operation.error==="conflict"?t("team.conflict"):operation.error}</SettingsFeedback>}
{operation.error==="conflict"&&<button className="btn" type="button" onClick={onReload}>{t("team.reloadSaved")}</button>}
<SettingsField label={t("team.memoryDescription")}><input className="mem-input set-grow" value={draft.description} disabled={operation.busy} maxLength={400} onChange={e=>setDraft({...draft,description:e.target.value,name:draft.id?draft.name:e.target.value})}/></SettingsField>
<SettingsField label={t("team.memoryBody")} stacked><textarea className="mem-textarea" rows={5} value={draft.body} disabled={operation.busy} maxLength={16000} onChange={e=>setDraft({...draft,body:e.target.value})}/></SettingsField>
<div className="agent-preset-row__actions"><button className="btn btn--primary" disabled={!writable||!valid||operation.busy}>{t("common.save")}</button><button className="btn" type="button" disabled={operation.busy} onClick={()=>guard.leave(onCancel)}>{t("common.cancel")}</button>
{draft.id&&<InlineConfirmButton label={t("team.memoryArchive")} confirmLabel={t("team.memoryArchiveConfirm")} cancelLabel={t("common.cancel")} disabled={!writable||operation.busy} onConfirm={async()=>{await commit(true);}}/>}
</div>
</form>;
}

function TeamReviewPreferences({team,reload}:{team:TeamView;reload:()=>Promise<unknown>}){
const t=useT(),operation=useTeamOperation();
const initial={enabled:team.roster.prefs.memoryReview,model:team.roster.prefs.memoryReviewModel??""};
const [draft,setDraft]=useState(initial),[saved,setSaved]=useState(initial),[revision,setRevision]=useState(team.roster.revision);
const [status,setStatus]=useState<TeamMemoryReviewStatus[]>([]),[error,setError]=useState("");
useEffect(()=>{let active=true;void app.GetTeamMemoryReviewStatus().then(list=>{if(active)setStatus(list);},cause=>{if(active)setError(String(cause));});return()=>{active=false;};},[team]);
const dirty=JSON.stringify(draft)!==JSON.stringify(saved);
useEffect(()=>{if(!dirty&&!operation.busy){const value={enabled:team.roster.prefs.memoryReview,model:team.roster.prefs.memoryReviewModel??""};setDraft(value);setSaved(value);setRevision(team.roster.revision);}},[team.roster.revision,team.roster.prefs,dirty,operation.busy]);
const save=()=>operation.run({draft,revision},requestId=>app.SaveTeamMemoryPreferences({expectedRevision:revision,requestId,...draft}),async()=>{setSaved(draft);await reload();notifyTeamChanged();});
useSettingsDraft({label:t("team.memoryReview"),order:2,dirty,busy:operation.busy,canSave:team.writable,save,discard:()=>setDraft(saved)});
return <SettingsSection title={t("team.memoryReview")} description={t("team.memoryReviewHint")}>
{(operation.error||error)&&<SettingsFeedback kind="error">{operation.error==="conflict"?t("team.conflict"):operation.error||error}</SettingsFeedback>}
<SettingsField label={t("team.memoryReview")}><input type="checkbox" checked={draft.enabled} disabled={!team.writable||operation.busy} onChange={e=>setDraft({...draft,enabled:e.target.checked})}/></SettingsField>
<SettingsField label={t("team.memoryReviewModel")} hint={t("team.memoryReviewModelHint")}><input className="mem-input set-grow" value={draft.model} disabled={!team.writable||operation.busy} onChange={e=>setDraft({...draft,model:e.target.value})}/></SettingsField>
<button className="btn" type="button" disabled={!team.writable||!dirty||operation.busy} onClick={()=>void save()}>{t("common.save")}</button>
{status.slice(-5).reverse().map((item,index)=><p role="status" key={`${item.at}:${index}`}>{item.agentId} · {new Date(item.at).toLocaleString()} · {item.outcome==="failed"?`${t("team.memoryReviewFailed")}: ${item.error??""}`:`+${item.added} / ~${item.edited} / −${item.archived}`}</p>)}
</SettingsSection>;
}
59 changes: 59 additions & 0 deletions desktop/frontend/src/components/TeamScheduleSettings.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
import { useCallback, useEffect, useRef, useState } from "react";
import type { Schedule, TeamScheduleView, TeamView } from "../generated/desktopContract.generated";
import { app } from "../lib/bridge";
import { useT } from "../lib/i18n";
import { notifyTeamChanged } from "../lib/useTeam";
import { useTeamOperation } from "../lib/useTeamOperation";
import { InlineConfirmButton } from "./InlineConfirmButton";
import { SettingsFeedback, useSettingsDraft } from "./SettingsExperience";
import { SettingsField, SettingsSection } from "./SettingsForm";
import { SettingsSelect } from "./SettingsSelect";

export function TeamScheduleSettings({team}:{team:TeamView}){
const t=useT(),operation=useTeamOperation();
const [view,setView]=useState<TeamScheduleView|null>(null),[error,setError]=useState("");
const [editing,setEditing]=useState<{schedule:Schedule;revision:number;rosterRevision:number}|null>(null),[notice,setNotice]=useState("");
const sequence=useRef(0);
const reload=useCallback(async()=>{const request=++sequence.current;try{const result=await app.GetTeamSchedules();if(sequence.current===request){setView(result);setError("");}}catch(cause){if(sequence.current===request)setError(String(cause));}},[]);
useEffect(()=>{void reload();return()=>{sequence.current++;};},[reload,team]);
const begin=(schedule:Schedule)=>{if(view)setEditing({schedule,revision:view.revision,rosterRevision:team.roster.revision});};
const blank=():Schedule=>({id:"",name:"",agent:team.roster.agents[0]?.id??"",prompt:"",repeat:"once",timezone:Intl.DateTimeFormat().resolvedOptions().timeZone,days:[],anchor:new Date(Date.now()+3600000).toISOString(),enabled:true,next:"0001-01-01T00:00:00Z",lastAt:"0001-01-01T00:00:00Z",intervalMinutes:60,clock:"09:00"});
return <SettingsSection title={t("team.schedules")} description={t("team.scheduleHint")}>
{(error||operation.error)&&<SettingsFeedback kind="error">{operation.error==="conflict"?t("team.conflict"):error||operation.error}</SettingsFeedback>}
{notice&&<SettingsFeedback kind="success">{notice}</SettingsFeedback>}
{editing?<TeamScheduleEditor key={`${editing.schedule.id}:${editing.revision}`} initial={editing.schedule} revision={editing.revision} rosterRevision={editing.rosterRevision} team={team} onSaved={async()=>{setEditing(null);await reload();notifyTeamChanged();}} onCancel={()=>setEditing(null)}/>:<>
<button className="btn btn--small" type="button" disabled={!team.writable||!team.roster.agents.length||!view} onClick={()=>begin(blank())}>{t("team.scheduleNew")}</button>
{view?.schedules.map(sc=><article className="cap-skill-card" key={sc.id}><h3>{sc.name}</h3><p className="cap-skill-card__desc">{sc.prompt}</p><p>{team.roster.agents.find(a=>a.id===sc.agent)?.name??team.roster.groups.find(g=>g.id===sc.group)?.name??t("team.memoryTargetGone")} · {sc.timezone}{sc.enabled&&sc.next&&sc.next!=="0001-01-01T00:00:00Z"?` · ${new Date(sc.next).toLocaleString()}`:""}</p><p role="status">{sc.lastOutcome??""}</p>
<div className="agent-preset-row__actions"><button className="btn btn--small" type="button" disabled={!team.writable||operation.busy} onClick={()=>begin(sc)}>{t("common.edit")}</button>
<button className="btn btn--small" type="button" disabled={!team.writable||operation.busy} onClick={()=>void operation.run({id:sc.id,revision:view.revision},requestId=>app.RunTeamSchedule({id:sc.id,expectedRevision:view.revision,requestId}),async()=>{setNotice(t("team.scheduleAccepted"));await reload();})}>{t("team.scheduleRun")}</button>
<InlineConfirmButton label={t("common.delete")} confirmLabel={t("common.delete")} cancelLabel={t("common.cancel")} danger disabled={!team.writable||operation.busy} onConfirm={async()=>{await operation.run({sc,revision:view.revision,rosterRevision:team.roster.revision,delete:true},requestId=>app.SaveTeamSchedule({schedule:sc,expectedRevision:view.revision,expectedRosterRevision:team.roster.revision,requestId,delete:true}),async()=>{await reload();notifyTeamChanged();});}}/>
</div>
</article>)}
</>}
</SettingsSection>;
}

function TeamScheduleEditor({initial,revision,rosterRevision,team,onSaved,onCancel}:{initial:Schedule;revision:number;rosterRevision:number;team:TeamView;onSaved:()=>Promise<void>;onCancel:()=>void}){
const t=useT(),operation=useTeamOperation(),[draft,setDraft]=useState(initial);
const patch=(value:Partial<Schedule>)=>setDraft(old=>({...old,...value}));
const target=draft.group?`group:${draft.group}`:`agent:${draft.agent??""}`;
const targets=[...team.roster.agents.map(a=>({value:`agent:${a.id}`,label:a.name})),...team.roster.groups.filter(g=>!g.archived).map(g=>({value:`group:${g.id}`,label:g.name||g.id}))];
const valid=Boolean(draft.name.trim()&&draft.prompt.trim()&&targets.some(item=>item.value===target)&&draft.timezone.trim()&&Number.isFinite(Date.parse(draft.anchor))&&(draft.repeat!=="every"||((draft.intervalMinutes??0)>=10&&(draft.intervalMinutes??0)<=10080))&&(draft.repeat!=="weekly"||draft.days.length>0));
const save=()=>operation.run({draft,revision,rosterRevision},requestId=>app.SaveTeamSchedule({schedule:draft,expectedRevision:revision,expectedRosterRevision:rosterRevision,requestId,delete:false}),onSaved);
const dirty=JSON.stringify(draft)!==JSON.stringify(initial);
const guard=useSettingsDraft({label:t("team.schedules"),order:4,dirty,busy:operation.busy,canSave:valid&&team.writable,save,discard:()=>setDraft(initial)});
return <form aria-busy={operation.busy} onSubmit={event=>{event.preventDefault();if(valid)void save();}}>
{operation.error&&<SettingsFeedback kind="error">{operation.error==="conflict"?t("team.conflict"):operation.error}</SettingsFeedback>}
<SettingsField label={t("team.name")}><input className="mem-input set-grow" value={draft.name} maxLength={60} disabled={operation.busy} onChange={e=>patch({name:e.target.value})}/></SettingsField>
<SettingsField label={t("team.scheduleTarget")}><SettingsSelect value={target} options={targets} disabled={operation.busy} onValueChange={value=>{const [kind,id]=value.split(":");patch({agent:kind==="agent"?id:"",group:kind==="group"?id:""});}}/></SettingsField>
<SettingsField label={t("team.schedulePrompt")} stacked><textarea className="mem-textarea" rows={4} value={draft.prompt} maxLength={2000} disabled={operation.busy} onChange={e=>patch({prompt:e.target.value})}/></SettingsField>
<SettingsField label={t("team.scheduleRepeat")}><SettingsSelect value={draft.repeat} options={[{value:"once",label:t("team.scheduleOnce")},{value:"daily",label:t("team.scheduleDaily")},{value:"weekly",label:t("team.scheduleWeekly")},{value:"every",label:t("team.scheduleEvery")}]} disabled={operation.busy} onValueChange={repeat=>patch({repeat})}/></SettingsField>
<SettingsField label={t("team.scheduleTimezone")}><input className="mem-input set-grow" value={draft.timezone} disabled={operation.busy} onChange={e=>patch({timezone:e.target.value})}/></SettingsField>
{(draft.repeat==="once"||draft.repeat==="every")&&<SettingsField label={t("team.scheduleAnchor")}><input className="mem-input set-grow" value={draft.anchor} placeholder="2026-11-04T09:00:00+08:00" disabled={operation.busy} onChange={e=>patch({anchor:e.target.value})}/></SettingsField>}
{(draft.repeat==="daily"||draft.repeat==="weekly")&&<SettingsField label={t("team.scheduleClock")}><input className="mem-input" type="time" value={draft.clock??"09:00"} disabled={operation.busy} onChange={e=>patch({clock:e.target.value})}/></SettingsField>}
{draft.repeat==="every"&&<SettingsField label={t("team.scheduleInterval")}><input className="mem-input" type="number" min={10} max={10080} value={draft.intervalMinutes??60} disabled={operation.busy} onChange={e=>patch({intervalMinutes:Number(e.target.value)})}/></SettingsField>}
{draft.repeat==="weekly"&&<SettingsField label={t("team.scheduleDays")}><div className="agent-preset-row__actions">{[0,1,2,3,4,5,6].map(day=><label key={day}><input type="checkbox" checked={draft.days.includes(day)} disabled={operation.busy} onChange={e=>patch({days:e.target.checked?[...draft.days,day]:draft.days.filter(d=>d!==day)})}/>{new Intl.DateTimeFormat(undefined,{weekday:"short"}).format(new Date(2023,0,1+day))}</label>)}</div></SettingsField>}
<SettingsField label={t("team.scheduleEnabled")}><input type="checkbox" checked={draft.enabled} disabled={operation.busy} onChange={e=>patch({enabled:e.target.checked})}/></SettingsField>
<div className="settings-save-bar"><button className="btn" type="button" disabled={operation.busy} onClick={()=>guard.leave(onCancel)}>{t("common.cancel")}</button><button className="btn btn--primary" disabled={!valid||!dirty||!team.writable||operation.busy}>{t("common.save")}</button></div>
</form>;
}
Loading
Loading