Repository navigation
feat(team): private secrets and command injection / 专用密钥与命令注入 - #152
Merged
Merged
Conversation
SivanCola
marked this pull request as ready for review
November 3, 2026 08:41
# Conflicts: # internal/tool/team.go
Deploying deepzora-website with
|
| Latest commit: |
d28a9f3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://634fc8a2.deepzora-website.pages.dev |
| Branch Preview URL: | https://codex-team-port-6-secrets.deepzora-website.pages.dev |
SivanCola
changed the base branch from
codex/team-port-5-memory-schedules
to
main
November 3, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Documentation and compatibility
Documentation-impact: Updated bilingual Team documentation and the implementation ledger. New secret metadata is versioned, revision checked and stores credential references only; unknown schema refuses writes. Slots are local unencrypted files readable by same-user programs. Existing provider credentials and ordinary-session behavior are preserved. One Team-only request tool intentionally extends the Team catalog.
Related issues
Incremental base: #151. Adapted mechanisms from esengine/DeepSeek-Reasonix #14641 (
ac40a8944f5771f190c4a090da4dcb9af3b2cfd8) and its fixed cumulative snapshot. CLI commands/outbox are excluded; structured mentions and group pagination live in #149. This is layer 6 of 7, not a complete port or release.Complete-stack qualification
This PR remains scoped to its own layer. The completed seven-layer stack, native DMG/DEB/NSIS acceptance, real-model evidence and compatibility limits are tracked in #153 and the qualification record. Merge follows current-head checks and dependency order; release is outside this PR.
Incremental review follow-up
Reviewed only against layer 5. Metadata is validated before plaintext creation; new slots have durable creation intents reconciled against the committed book after failure or restart. Committed/retired slots are preserved, unknown or corrupt books stop cleanup, and untracked legacy files are not swept. Regression covers invalid purpose/capacity, callback/rename failure, uncertain commit, restart and intent failure; Desktop secret tests and config/roster race tests pass. The standalone layer-6 feature gate remains closed.
CI lifecycle fixture follow-up
The macOS failure exposed test teardown that closed services without joining controller finalization and autosave producers. The layer-4 fixture now quiesces/join all visible and detached owners before closing stores; navigation also joins the replaced controller. Two deterministic regressions fail with the prior cleanup, and focused race/repeated tests pass. These changes affect tests only and preserve the native-qualified production code. The original CI ENOTEMPTY ordering was not naturally reproduced locally.
Final head
153de7e4e981d094e0e1bda445703149c3d14224passed CI run 41624468950 attempt 2 and CodeQL. The initial Windows root job was cancelled at the existing 35-minute job limit and exposed no downloadable log or root report; a job-only retry passed all root packages with the same source and limits. No timeout increase or test suppression was applied; the first attempt remains a failed/cancelled record, not a proven code defect.