Repository navigation
fix(desktop): let Windows caption buttons take the shell bar's surface - #170
Merged
Merged
Conversation
The caption buttons kept an elevated surface, border and shadow whenever the workspace panel was open, and a dock-coloured surface in Creation. Both rules predate the full-width shell bar: the buttons now always sit on that bar, so their own surface showed as a white box beside it. Fixes #135
This was referenced Nov 10, 2026
Closed
Closed
SivanCola
added a commit
that referenced
this pull request
Nov 10, 2026
* docs(release): add 0.0.6 release notes Covers the changes merged since 0.0.5: model display names (#172), the Windows caption button surface (#170), consistent base theme names (#171), shutdown step diagnostics (#169) and Electron 45 (#168). The open shutdown stall in #126 is listed as a known risk. * chore(release): approve unsigned Windows 0.0.6 Stable exception --------- Co-authored-by: zumac <zumac@sgmacdeMini-1.lan>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows, opening the right-hand workspace panel showed the minimize/maximize/close buttons in a white box next to the grey shell bar (#135, and item 1 of #162).
background: var(--bg-elev), a border and a shadow, cleared only while the workspace panel was closed. Creation replaced that with the dock's colour.#f5f6f9and--bg-elevis near-white, which is the mismatch in the report.Verification
app-chrome-tabs.test.ts: the buttons' final background is transparent and no dock-state or Creation rule paints them. That file (75 assertions),image-viewer-window-controls.test.tsandsettings-responsive-layout.test.tspass.Documentation and compatibility
Presentation only. No persisted data, RPC contract or provider-visible changes.
Cache-impact: none.
Cache-guard: n/a
Related issues
Fixes #135. Refs #162 (item 1 only).
🤖 Generated with Claude Code