Repository navigation
fix(ci): wait for SimplySign credential form readiness - #179
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first v0.0.7 signing attempt selected SimplySign's transient splash window before the credential form existed. Later popup recovery treated the real login form as a dialog and never submitted credentials correctly.
Vendor the pinned MIT-licensed authentication helper and wait for the actual login control roles (two edit controls and OK) before sending credentials. Popup recovery only targets acknowledgement dialogs with no edit controls. The verified installer is shared with a credential-free probe, which runs on hosted Windows CI; ambiguous forms, process exit, and timeout fail before input. Authentication screenshots remain disabled.
Validation: 273 Node tests passed (one existing native DMG skip), release-signing Go tests and contract validation passed, actionlint and diff checks passed. The credential-free official Windows client probe passed, identifying the actual WinForms edit/button classes and ignoring the splash. Windows CI also exercises deterministic regressions in both PowerShell runtimes. A protected-main signing smoke test will verify authentication and actual x64/ARM64 signatures after merge.