Skip to content

Use bulk conversion in Write8BitColor #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JimBobSquarePants merged 4 commits into from
Nov 16, 2020
Merged

Use bulk conversion in Write8BitColor #1428

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
247834f
Use bulk conversion to rgba in Write8BitColor
brianpopow Nov 15, 2020
e4d0ffe
Dont use the default config in ToRgba32
brianpopow Nov 15, 2020
3970510
Use colorPalette span as destination of bulk conversion
brianpopow Nov 15, 2020
04881fd
Merge branch 'master' into bp/bmp8BitBulkConv
brianpopow Nov 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Dont use the default config in ToRgba32
  • Loading branch information
@brianpopow
brianpopow committed Nov 15, 2020
commit e4d0ffe6dbce456226c57af34e0b58c1374ad105
2 changes: 1 addition & 1 deletion src/ImageSharp/Formats/Bmp/BmpEncoderCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ private void Write8BitColor<TPixel>(Stream stream, ImageFrame<TPixel> image, Spa
Span<Rgba32> rgbColors = rgbColorsBuffer.GetSpan();

ReadOnlySpan<TPixel> quantizedColors = quantized.Palette.Span;
PixelOperations<TPixel>.Instance.ToRgba32(Configuration.Default, quantizedColors, rgbColors);
PixelOperations<TPixel>.Instance.ToRgba32(this.configuration, quantizedColors, rgbColors);

int idx = 0;
foreach (Rgba32 color in rgbColors)
Expand Down