Skip to content

Add SSE2 version of Vp8Sse4X4 #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JimBobSquarePants merged 13 commits into from
Nov 10, 2021
Merged

Add SSE2 version of Vp8Sse4X4 #1817

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8d19c28
Add sse2 version of Vp8Sse4X4
brianpopow Nov 8, 2021
99a3510
Avoid pinning
brianpopow Nov 9, 2021
9756adc
Merge remote-tracking branch 'origin/master' into bp/sse4X4
brianpopow Nov 9, 2021
de3140b
Use Numerics.ReduceSum(sum)
brianpopow Nov 9, 2021
80a826f
Remove not needed clear
brianpopow Nov 9, 2021
5abd774
Add Vp8Sse4X4 sse tests
brianpopow Nov 9, 2021
5ead844
Use Array.Clear to reset the arrays
brianpopow Nov 9, 2021
7312b1a
Dont use slice
brianpopow Nov 9, 2021
3dd7c8e
Remove unnecessary Clear() and scratch buffer
brianpopow Nov 9, 2021
5630b25
Remove more unnecessary Clear's
brianpopow Nov 9, 2021
dcca236
Merge remote-tracking branch 'origin/master' into bp/sse4X4
brianpopow Nov 9, 2021
7e20c5d
Rename Vp8Sse methods
brianpopow Nov 10, 2021
1997d59
Fix build error due to renaming
brianpopow Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Dont use slice
  • Loading branch information
@brianpopow
brianpopow committed Nov 9, 2021
commit 7312b1a8389c1824409205a5bbfd4ad14224d9c3
18 changes: 10 additions & 8 deletions src/ImageSharp/Formats/Webp/Lossy/LossyUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,16 @@ public static int Vp8Sse4X4(Span<byte> a, Span<byte> b)
if (Sse2.IsSupported)
{
// Load values.
Vector128<byte> a0 = Unsafe.As<byte, Vector128<byte>>(ref MemoryMarshal.GetReference(a));
Vector128<byte> a1 = Unsafe.As<byte, Vector128<byte>>(ref MemoryMarshal.GetReference(a.Slice(WebpConstants.Bps, 8)));
Vector128<byte> a2 = Unsafe.As<byte, Vector128<byte>>(ref MemoryMarshal.GetReference(a.Slice(WebpConstants.Bps * 2, 8)));
Vector128<byte> a3 = Unsafe.As<byte, Vector128<byte>>(ref MemoryMarshal.GetReference(a.Slice(WebpConstants.Bps * 3, 8)));
Vector128<byte> b0 = Unsafe.As<byte, Vector128<byte>>(ref MemoryMarshal.GetReference(b));
Vector128<byte> b1 = Unsafe.As<byte, Vector128<byte>>(ref MemoryMarshal.GetReference(b.Slice(WebpConstants.Bps, 8)));
Vector128<byte> b2 = Unsafe.As<byte, Vector128<byte>>(ref MemoryMarshal.GetReference(b.Slice(WebpConstants.Bps * 2, 8)));
Vector128<byte> b3 = Unsafe.As<byte, Vector128<byte>>(ref MemoryMarshal.GetReference(b.Slice(WebpConstants.Bps * 3, 8)));
ref byte aRef = ref MemoryMarshal.GetReference(a);
Vector128<byte> a0 = Unsafe.As<byte, Vector128<byte>>(ref aRef);
Vector128<byte> a1 = Unsafe.As<byte, Vector128<byte>>(ref Unsafe.Add(ref aRef, WebpConstants.Bps));
Vector128<byte> a2 = Unsafe.As<byte, Vector128<byte>>(ref Unsafe.Add(ref aRef, WebpConstants.Bps * 2));
Vector128<byte> a3 = Unsafe.As<byte, Vector128<byte>>(ref Unsafe.Add(ref aRef, WebpConstants.Bps * 3));
ref byte bRef = ref MemoryMarshal.GetReference(b);
Vector128<byte> b0 = Unsafe.As<byte, Vector128<byte>>(ref bRef);
Vector128<byte> b1 = Unsafe.As<byte, Vector128<byte>>(ref Unsafe.Add(ref bRef, WebpConstants.Bps));
Vector128<byte> b2 = Unsafe.As<byte, Vector128<byte>>(ref Unsafe.Add(ref bRef, WebpConstants.Bps * 2));
Vector128<byte> b3 = Unsafe.As<byte, Vector128<byte>>(ref Unsafe.Add(ref bRef, WebpConstants.Bps * 3));

// Combine pair of lines.
Vector128<int> a01 = Sse2.UnpackLow(a0.AsInt32(), a1.AsInt32());
Expand Down