Skip to content

Upgrade dependencies #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hugo Tunius (k0nserv) merged 9 commits into from
Jan 16, 2018
Merged

Upgrade dependencies #449

Hugo Tunius (k0nserv) merged 9 commits into from
Jan 16, 2018

Conversation

@k0nserv
Copy link
Contributor

@k0nserv Hugo Tunius (k0nserv) commented Jan 16, 2018

No description provided.

@backpackbot
Copy link

Backpack Bot (backpackbot) commented Jan 16, 2018 •
edited
Loading

Warnings
⚠️

One or more packages have changed, but changelog.md wasn't updated.
⚠️

Package source files (e.g. package/packageName/src/packageName.js) were updated, but snapshots weren't. Have you checked that the tests still pass?
⚠️

package-lock.json was updated. Ensure that this was intentional.

Generated by 🚫 dangerJS

shaundon
shaundon previously approved these changes Jan 16, 2018
View reviewed changes
Copy link
Contributor

@shaundon Shaun Donnelly (shaundon) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; nice work upgrading Danger too.

@k0nserv
Copy link
Contributor Author

Hugo Tunius (k0nserv) commented Jan 16, 2018

I'm not done :)

@shaundon
Copy link
Contributor

Shaun Donnelly (shaundon) commented Jan 16, 2018

You should add the WIP label then 😉

@k0nserv
Copy link
Contributor Author

Hugo Tunius (k0nserv) commented Jan 16, 2018

Good shout :)

@k0nserv Hugo Tunius (k0nserv) changed the title Upgrade dependencies WIP: Upgrade dependencies Jan 16, 2018
@k0nserv Hugo Tunius (k0nserv) changed the title WIP: Upgrade dependencies Upgrade dependencies Jan 16, 2018
matteo-hertel
matteo-hertel reviewed Jan 16, 2018
View reviewed changes
native/packages/react-native-bpk-component-card/src/__snapshots__/BpkCard-test.android.js.snap Outdated
accessibilityLabel="Example Card"
background={undefined}
onPress={[Function]}
onPress={[MockFunction]}
Copy link
Contributor

@matteo-hertel Matteo Hertel (matteo-hertel) Jan 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking, is this change because of the Jest update to 22?

Copy link
Contributor Author

@k0nserv Hugo Tunius (k0nserv) Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah they've changed the serialization of jest.fn to be clearer. See jestjs/jest#4668

matthewdavidson
matthewdavidson previously approved these changes Jan 16, 2018
View reviewed changes
Copy link
Contributor

@matthewdavidson Matt Davidson-Loubet (matthewdavidson) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

package.json Outdated
"check-owners": "npm whoami && ( node scripts/npm/get-owners.js | grep -E $(npm whoami) ) && node scripts/npm/check-owners.js",
"publish": "npm run check-owners && npm run build && git pull --rebase && npm run flow stop && npm run test && lerna publish",
"danger": "danger",
"danger:ci": "danger ci",
Copy link
Contributor

@matthewdavidson Matt Davidson-Loubet (matthewdavidson) Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is only one task for "danger", keep it as "danger"

@k0nserv Hugo Tunius (k0nserv) merged commit 025144b into master Jan 16, 2018
@k0nserv Hugo Tunius (k0nserv) deleted the upgrade-dependencies branch January 16, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@matteo-hertel Matteo Hertel (matteo-hertel) matteo-hertel left review comments

@shaundon Shaun Donnelly (shaundon) shaundon left review comments

@matthewdavidson Matt Davidson-Loubet (matthewdavidson) matthewdavidson left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@k0nserv @backpackbot @shaundon @matthewdavidson @matteo-hertel