Skip to content

Wip test hack #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Wip test hack #128

wants to merge 2 commits into from

Conversation

hjmjohnson
Copy link
Member

No description provided.

@hjmjohnson hjmjohnson requested a review from jcfr March 15, 2020 14:48
@hjmjohnson hjmjohnson self-assigned this Mar 15, 2020
hjmjohnson
hjmjohnson commented Mar 15, 2020
View reviewed changes
Copy link
Member Author

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcfr @lassoan

I think this PR needs to be downloaded to a local computer with valid docker installation.

docker login # Use a login that has push capabilities to https://hub.docker.com/r/slicer/slicerexecutionmodel
cd SlicerExecutionModel/test/Docker
make && make push

@jcfr
Copy link
Member

jcfr commented Mar 15, 2020

Thanks 👍

I should be able to test this tomorrow morning.

@hjmjohnson
Copy link
Member Author

@jcfr See #127 for the non-wip version reaady for commit.

@hjmjohnson
Copy link
Member Author

Thanks 👍

I should be able to test this tomorrow morning.

Can we merge #127 so that we can test and merge #126?

@hjmjohnson hjmjohnson closed this Mar 21, 2020
@hjmjohnson hjmjohnson reopened this Mar 22, 2020
@hjmjohnson
Copy link
Member Author

@jcfr The docker image still needs to be updated.

@jcfr
Copy link
Member

jcfr commented Mar 23, 2020

The docker image still needs to be updated.

Thanks for the ping and thanks for your patience 🙏

This past few days have been crazy and I missed this.

hjmjohnson and others added 2 commits September 5, 2020 09:15
@hjmjohnson
ENH: Update TCLAP to match master upstream branch
5729a74 
git clone https://git.code.sf.net/p/tclap/code

Manually merge changes from d6419ab71623821c5dd02be3bc2835577fa7d525
@hjmjohnson
WIP: DO NOT MERGE, testing CI
e5cef6d
@hjmjohnson
Copy link
Member Author

This is now duplicated. See #129

@hjmjohnson hjmjohnson closed this Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcfr jcfr Awaiting requested review from jcfr

Assignees

@hjmjohnson hjmjohnson

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hjmjohnson @jcfr