Skip to content

Conversation

@Apointos
Copy link

@Apointos Apointos commented Jul 9, 2014

I have updated the README file so that it utilizes more of Markdown's features. I have properly formatted the code blocks, updated the headers and fixed a large amount of inconsistent formatting.

I have also rewritten a few of the text blocks to make them easier to read.

@jantje
Copy link
Member

jantje commented Jul 9, 2014

Looks good. I would merge but it seems automatic merge is not (yet) possible
Will look into this later.

@wimjongman
Copy link
Member

Can't you just pull?

@jantje
Copy link
Member

jantje commented Jul 9, 2014

it states "We can’t automatically merge this pull request. "

@wimjongman
Copy link
Member

I see.@Apointos must first rebase and then create a new pull request.

@jantje
Copy link
Member

jantje commented Jul 9, 2014

Can you see that because of Apointos:patch-1 at the top of this page?
@Apointos can you rebase and create a new pull request?

@Apointos
Copy link
Author

It seems commit ed794f8 fixed most of my PR was going to change 😄. This PR is no longer necessary.

@Apointos Apointos closed this Jul 10, 2014
@jantje
Copy link
Member

jantje commented Jul 10, 2014

OK txs for the feedback

jantje added a commit that referenced this pull request Jul 10, 2014
amorellgarcia pushed a commit to amorellgarcia/arduino-eclipse-plugin that referenced this pull request Jul 10, 2014
When including new bundles you need to add them to the feature and to this parent pom.
@kigster
Copy link
Contributor

kigster commented Jul 11, 2014

Wow great minds think alike :) Sorry we ended up making nearly the same changes on the same day! What a coincidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants