Fix Java Lib path for Mac OS X

[ffurlanetto]

No description provided.

[jantje]

can you give some explanation about this?
What are the symptoms that happen without this fix?
Is this for all ide versions?

[ffurlanetto]

Hi,
Sorry for the missing detaisl, It seems the path to the version.txt file in the Arduino build for Mac OS X has changed with the latest version (1.5.7).
The fix should be changed to try the old path and then the new (because at this time we don't know the version of Arduino installed)

[jantje]

So if I accept the pull request as it is right now the plugin will only work with 1.5.7 on mac?

[wimjongman]

yes because the only change is this:

• public static final String ArduinoIdeSuffix_MAC =
  "Contents/Resources/Java";
• public static final String ArduinoIdeSuffix_MAC = "Contents/Java";

On Sun, Jul 27, 2014 at 7:42 PM, jantje [email protected] wrote:

So if I accept the pull request as it is right now the plugin will only
work with 1.5.7 on mac?

—
Reply to this email directly or view it on GitHub
#180 (comment)
.

[ffurlanetto]

Yes, so you can close this pull request.. i will fix the code later and submit a new pull request... or you do the changes yourself... as you prefer... ;-)

regards,

[jantje]

@wimjongman Do you confirm the issue on arduino IDE 1.5.7?

[wimjongman]

I don't know. My regular os is Windows.

On Tue, Jul 29, 2014 at 12:27 AM, jantje [email protected] wrote:

@wimjongman https://github.com/wimjongman Do you confirm the issue on
arduino IDE 1.5.7?

—
Reply to this email directly or view it on GitHub
#180 (comment)
.

[xaljox]

I noticed the issue with changed paths also on the Mac with 1.5.7. But reading other threads it seems that there is more like the missing make.

Op 29 jul. 2014, om 00:27 heeft jantje [email protected] het volgende geschreven:

@wimjongman Do you confirm the issue on arduino IDE 1.5.7?

—
Reply to this email directly or view it on GitHub.

[jantje]

yes 1.5.7 dropped the makefile utility.
If you do not have a makefile tool in your path you will need to place one in your path.

[jantje]

Och and thanks for the confirmation.

[jantje]

the latest version should fix this issue. can you have a tests wether this works in with arduino ide 1.5.6 and 1.5.7 on mac?

[studleylee]

You seem to be forcing the paths to be related to USER.HOME when they should be able to be placed anywhere.
in COMMON.JAVA ~line:616
System.getProperty("user.home")

public static String getDefaultPrivateLibraryPath() {
IPath homPath = new Path(System.getProperty("user.home"));
return homPath.append("Arduino").append("libraries").toString();
}

Also issue in ArduinoPreferencePage.java ~line:251 you are forcing bad assumptions:
/**

• testStatus test whether the provided information is OK. Here the code checks whether there is a hardware\arduino\board.txt file under the
• provide path.
  *
• @return true if the provided info is OK; False if the provided info is not OK
  *
• @author Jan Baeyens
  *
  */
  private boolean testStatus() {
  String ErrorMessage = "";
  String Seperator = "";

// Validate the arduino path
Path arduinoFolder = new Path(mArduinoIdePath.getStringValue());
File arduinoBoardFile = arduinoFolder.append(ArduinoConst.LIB_VERSION_FILE).toFile();
boolean isArduinoFolderValid = arduinoBoardFile.canRead();
if (isArduinoFolderValid) {
Path BoardFile = new Path(mArduinoIdePath.getStringValue());
if (!BoardFile.equals(mPrefBoardFile)) {
mPrefBoardFile = BoardFile;
mArduinoIdeVersion.setStringValue(ArduinoHelpers.GetIDEVersion(BoardFile));
}
} else {
ErrorMessage += Seperator + "Arduino folder is not correct!";
Seperator = "/n";
}