Fix for #394, adding config parameter for RST/DTR flags in serial connection #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int stopbits; | ||
| boolean monitor = false; | ||
|
|
||
| // whether to pull DTR to GND during reset or not |
Member
There was a problem hiding this comment.
This comment is wrong. As to the jssc doc It should state "initial state of RTS&DTR line(ON/OFF)"
I would also add: Some boards reset when the serial port is opened with RTS and DTR low.
Basically the value is not used during reset so it is confusing to reference reset.
jssc doc I reference to http://java-simple-serial-connector.googlecode.com/svn/trunk/additional_content/javadoc/0.8/index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a boolean flag for a serial connection (COM Port) to configure the RST/DTR flags of the serial connection.
I testet it and can confirm it fixes #394 for me.