606: Remove dependency on org.eclipse.wb.core.lib #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
can you remove the conflict? |
Member
Author
|
I resolved the conflicts |
Member
|
I think I already did.
…On Dec 23, 2016, 16:49, at 16:49, jantje ***@***.***> wrote:
can you remove the conflict?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#608 (comment)
|
Member
|
Please do not remove pde. It is there for the osgi console.
Also jdt is quite handy to have around.
…On Dec 23, 2016, 15:41, at 15:41, Maarten Meijer ***@***.***> wrote:
Also remove PDE and JDT dependency, create a target file and change
config.ini to put the default workspace in path
~/Documents/sloeber-worksapce as default instead of the invisible and
non-selectable application root folder. This must also be best practice
on Linux and Windows with multiple users: each user gets his own
workspace.
You can view, comment on, or merge this pull request online at:
#608
-- Commit Summary --
* 606: Remove dependency on org.eclipse.wb.core.lib
* 606: Remove dependency on org.eclipse.wb.core.lib
-- File Changes --
M io.sloeber.product/arduino.product (2)
A io.sloeber.product/config/mac/config.ini (14)
A io.sloeber.product/neon-cdt-nebula.target (48)
M io.sloeber.ui/META-INF/MANIFEST.MF (2)
-- Patch Links --
https://github.com/jantje/arduino-eclipse-plugin/pull/608.patch
https://github.com/jantje/arduino-eclipse-plugin/pull/608.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#608
|
Member
|
Ok cool. Thanks Maarten.
Sent from TypeApp
…On Dec 23, 2016, 17:31, at 17:31, Maarten Meijer ***@***.***> wrote:
I resolved the conflicts
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#608 (comment)
|
Member
|
I actually also wonder whether PDE and JDT are a "must have" |
Member
|
Yes they are.
…On Dec 23, 2016, 18:01, at 18:01, jantje ***@***.***> wrote:
I actually also wonder whether PDE and JDT are a "must have"
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#608 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove PDE and JDT dependency, create a target file and change config.ini to put the default workspace in path ~/Documents/sloeber-worksapce as default instead of the invisible and non-selectable application root folder. This must also be best practice on Linux and Windows with multiple users: each user gets his own workspace.