Skip to content

Solve - Authorization on creation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solve - Authorization on creation #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/services/query.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ export interface QueryService<DTO, C = DeepPartial<DTO>, U = DeepPartial<DTO>> {
* @param item - the record to create.
* @returns the created record.
*/
createOne(item: C): Promise<DTO>
createOne(item: C, opts?: UpdateOneOptions<DTO>): Promise<DTO>

/**
* Creates a multiple record.
Expand Down
5 changes: 2 additions & 3 deletions packages/query-graphql/src/resolvers/create.resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,10 @@ export const Creatable =
@AuthorizerFilter({
operationGroup: OperationGroup.CREATE,
many: false
}) // eslint-disable-next-line @typescript-eslint/no-unused-vars
})
authorizeFilter?: Filter<DTO>
): Promise<DTO> {
// Ignore `authorizeFilter` for now but give users the ability to throw an UnauthorizedException
const created = await this.service.createOne(input.input.input)
const created = await this.service.createOne(input.input.input, { filter: authorizeFilter ?? {} })
if (enableOneSubscriptions) {
await this.publishCreatedEvent(created, authorizeFilter)
}
Expand Down
9 changes: 8 additions & 1 deletion packages/query-typeorm/src/services/typeorm-query.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
AggregateOptions,
AggregateQuery,
AggregateResponse,
applyFilter,
Class,
CountOptions,
DeepPartial,
Expand Down Expand Up @@ -191,9 +192,15 @@ export class TypeOrmQueryService<Entity>
* ```
* @param record - The entity to create.
*/
public async createOne(record: DeepPartial<Entity>): Promise<Entity> {
public async createOne(record: DeepPartial<Entity>, opts?: UpdateOneOptions<Entity>): Promise<Entity> {
const entity = await this.ensureIsEntityAndDoesNotExist(record)

const passesFilter = applyFilter(entity, opts.filter)

if (!passesFilter) {
throw new Error('Entity does not meet creation constraints')
}

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
return this.repo.save(entity)
Expand Down